Giter Club home page Giter Club logo

Comments (7)

openshift-bot avatar openshift-bot commented on July 17, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

from api.

sebasmannem avatar sebasmannem commented on July 17, 2024

So, since I did not receive any updates on this, my assumption is that this is either a bug with low priority, or it is expected behaviour.
I investigated how this is supposed to work (looking at k8s code) and how it is implemented within OpenShift.
Without help I cannot proceed investigation and/or propose fixes.
I can only update my issue with my personal fixes as into how I implemented it.

  1. Namespaces are automatically cleaned, no surprises there
  2. ArgoCD objects, RoleBindings and Secrets reside within the namespace and are cleaned together with the namespaces. I have not put any efforts into investigating wether this is also cleaned without cleaning the namespace itself.
  3. OpenShift objects (Quota, users, groups,
  4. Other items are within objects (such as items in ArgoCD AppSet listgenerators, and lines in ConfigMap Data) and are managed by custom finaliser code of our operator

from api.

sebasmannem avatar sebasmannem commented on July 17, 2024

For the OpenShift objects (item 3) I have currently implemented the following custom code:

  • controller detects that is being removed and runs generic finalize code
  • finalize code runs specific finalize codes for specific items (item 3 and 4, Quota, groups, users, and stuff in resources)
  • finalize code for groups deducts which groups where created by our operator (from main resource body) and removes as required. SImilar for other openshift stuff.

I would have loved it to be taken care of out of the box.
That would saved time and be less error prone, but we now have something that works for us.
I hope that this helps anyone else that might run into this.
If any questions, or an ambition to actually fix this, just ping us with comments in this issue.

from api.

sebasmannem avatar sebasmannem commented on July 17, 2024

Decided to leave this issue stale. Auto-close when rotten is fine...

from api.

openshift-bot avatar openshift-bot commented on July 17, 2024

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

from api.

openshift-bot avatar openshift-bot commented on July 17, 2024

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

from api.

openshift-ci avatar openshift-ci commented on July 17, 2024

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.