allow defining rook YAML files about dev-scripts HOT 10 CLOSED

OK, those things all make sense at first glance. Thanks for adding the details!

from dev-scripts.

What sorts of configuration changes do you anticipate needing?

from dev-scripts.

For downstream testing, we are setting the following:

• allowUnsupported: true so that we can install private versions of Ceph
• The rook versions are changed to specify the source of the containers (again, these are non-public)
• Both ROOK_ALLOW_MULTIPLE_FILESYSTEMS and ROOK_HOSTPATH_REQUIRES_PRIVILEGED
• The ceph container version is also changed to point to a private one

Some of these, like the container versions change often, while others are always set.

We also want to keep our validation as close as possible to what Rook is providing with their sample YAML files, so that we can catch regressions as soon as we rebase from upstream.

from dev-scripts.

There are a lot of things in this repo, and I'd like to understand the future of dev-scripts.git . Is is a long-term project? Will non-developers eventually use this?

from dev-scripts.

There are a lot of things in this repo, and I'd like to understand the future of dev-scripts.git . Is is a long-term project? Will non-developers eventually use this?

We are using this repository as a work space while we figure out what the installer needs to do. As that logic is ironed out, we are moving it into the go-based installer in https://github.com/openshift-metalkube/kni-installer. Eventually that fork of the openshift installer will be merged back, and we won't need much or any of this.

For now, these tools are the canonical way to set up a cluster, regardless of its purpose.

from dev-scripts.

@ktdreyer yeah I named the repo dev-scripts deliberately, to indicate this is a developer test-harness/prototype, and as @dhellmann says most logic will ultimately end up in kni-installer, openshift-install, or in a few cases the facet wrapper API (this should in general call kni-installer, but I think there will be a few additional cases like node auto-discovery which may not fit well into kni-installer's normal workflow, at least for now).

from dev-scripts.

Thanks Doug. I opened #265 to capture this. (Like Steve mentioned, it would be helpful to point new users at the facet repo as well.)

from dev-scripts.

Does this issue need to remain open? It sounds like PRs should just be submitted adding configuration to the rook setup as needed?

from dev-scripts.

I think this issue should remain open until a PR is submitted. For the reasons listed above, it is crucial to avoid hard-coding versions and sources for rook, ceph, and its containers. We have shifted focus to other targets for installation and I can't provide a PR to address this problem.

from dev-scripts.

rook is going to be dropped from dev-scripts, see #603 -- as you said, focus for installation will not be this PoC / demo integration, so best not to spend more energy on it

from dev-scripts.