Giter Club home page Giter Club logo

Comments (5)

shalako avatar shalako commented on July 21, 2024 1

The example in the spec has been updated, and we discuss in profile.md that cost is part of metadata and not defined in the spec.

api.md defines it as 'cost'
catalog-metadata.md defines it as 'costs'

The AppDirect broker uses costs, and this is used in the PWS web UI.

the structure of the 'cost' object is defined in terms of usd, which is obviously somewhat centered on a specific currency. As well as using that currency as a key in an object, which is not good.
It is unclear about how multiple costs combine together if they exist.

Though there are likely better schemas; the current one used by Pivotal does allow for multiple currencies:

"costs": [
  {
    "amount": {
      "usd": 649.0,
      "yen": 1000,
      "euro": 700
    },
    "unit": "MONTHLY"
  }
]

I would say we close this and if someone would like to see costs defined in the specification, they should open a new issue.

from servicebroker.

angarg12 avatar angarg12 commented on July 21, 2024

This is a relevant point for us because being able to display a service cost is a requirement of one of our customers.

I agree that we should do a pass on the spec and refine the current definition. It is in our TODO list but right now it is low priority so we haven't started working on it.

from servicebroker.

shalako avatar shalako commented on July 21, 2024

I believe the issue @MHBauer is referring to is only that the example in the api spec doesn't match the suggested field in http://docs.cloudfoundry.org/services/catalog-metadata.html.

I believe it's reasonable to update the example in the api spec to match, if it removes some confusion. It doesn't change the spec, as this field is not in the spec.

I'll include the change with my PR to migrate the spec from CF.

from servicebroker.

mattmcneeney avatar mattmcneeney commented on July 21, 2024

@shalako I believe this bug is resolved. Would you or @MHBauer like to confirm and close this issue? Thanks

from servicebroker.

MHBauer avatar MHBauer commented on July 21, 2024

Current spec and such seems fine now.

from servicebroker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.