Giter Club home page Giter Club logo

Comments (8)

erSitzt avatar erSitzt commented on June 29, 2024

... and for OnPremise Clusters it requires additional configs on the external loadbalancers

seems very counter intuitive for something that works very easy in all other regards..

from logstash-output-opensearch.

VijayanB avatar VijayanB commented on June 29, 2024

@erSitzt Thanks for creating an issue. Do you have a proposal that introduce this change without affecting existing configurations?

from logstash-output-opensearch.

erSitzt avatar erSitzt commented on June 29, 2024

Hi @VijayanB ,
maybe an additional parameter that, when set, overrides appending the port.

as it would mostly benefit users who want to use the host header only, it could be a true/false flag defaulting to false

use_http_host_header_only => true

something like this ? i'm bad at naming stuff, but you should get the intention ;)

from logstash-output-opensearch.

VijayanB avatar VijayanB commented on June 29, 2024

Hi @erSitzt , Thanks for suggestion. What do you think of creating new config called "port" with default value as 9200 and behavior as follows

  1. use defaults.

The below configuration will have host as "hostname:9200"

 opensearch {
        hosts       => ["hostname"]
        user        => "admin"
        password    => "admin"
        index       => "logstash-logs-%{+YYYY.MM.dd}"
    }
  1. override default port

The below configuration will have host as "hostname:1234"

 opensearch {
        hosts       => ["hostname"]
        port       => "1234"
        user        => "admin"
        password    => "admin"
        index       => "logstash-logs-%{+YYYY.MM.dd}"
    }
  1. Don't append port using above apporach

The below configuration will have host as "hostname"

 opensearch {
        hosts       => ["hostname"]
        port       => ""
        user        => "admin"
        password    => "admin"
        index       => "logstash-logs-%{+YYYY.MM.dd}"
    }

from logstash-output-opensearch.

erSitzt avatar erSitzt commented on June 29, 2024

It would be ok for my situation, but wouldnt it confuse people switching from ES to OpenSearch version ?

Because it's "Hosts" and not "Host" ?

the original examples were like this, so how would you handle different ports for different hosts ?

"127.0.0.1"
["127.0.0.1:9200","127.0.0.2:9200"]
["http://127.0.0.1"]
["https://127.0.0.1:9200"]
["https://127.0.0.1:9200/mypath"] (If using a proxy on a subpath)

My approach would only take affect when NO port is defined for any of the hosts and then NOT to default to 9200 to allow named based routing in a load-balancer

I think this would have less impact and cause less confusion for people familiar with logstash from Elastic

from logstash-output-opensearch.

erSitzt avatar erSitzt commented on June 29, 2024

I would prefer just to be able to opt out of this default here

calculate_property(uris, :port, nil, sniffing) || 9200

from logstash-output-opensearch.

erSitzt avatar erSitzt commented on June 29, 2024

hey @VijayanB is there any progress on this ?

from logstash-output-opensearch.

brijos avatar brijos commented on June 29, 2024

Sorry @erSitzt, the team has not had a chance to prioritize this work. We will review work across clients again in the Jul-Aug timeframe. This would be a good candidate for help wanted though so I'm adding the proper label.

from logstash-output-opensearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.