Giter Club home page Giter Club logo

Comments (4)

mpreisler avatar mpreisler commented on June 5, 2024

This is a pretty serious regression in all the maintenance branches. The issue was introduced in 40da1b6

As far as I can see, reverting this commit will fix the issue. It all stems from me misunderstanding what setsid --wait does

EDIT: --wait is needed to pass on the ssh exit code. At this point I don't know how to fix this. Maybe we can just ignore the ssh exit code when setsid doesn't support --wait and pass it on otherwise?

from scap-workbench.

mpreisler avatar mpreisler commented on June 5, 2024

I decided to use --wait if available and ignore the exit code if --wait is not available.

If SSH fails the user will get notified of it from stderr and stdout of the ssh process. The UX won't be perfect but it will be decent enough.

I will patch the code to check whether --wait is supported at configure time.

from scap-workbench.

mpreisler avatar mpreisler commented on June 5, 2024

fc6dd83 fixes the issue for v0-8 and v1-0. In those branches there is no configure-time check for setsid so we assume --wait is not supported.

from scap-workbench.

mpreisler avatar mpreisler commented on June 5, 2024

4997756 fixes the issue for v1-1. We check at configure time, use --wait if supported.

from scap-workbench.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.