Comments (2)
The PR mechanism is entirely designed around this feature 😉, please use it! PRs are best for quick integration and quick feedback/comments.
Also, I see two changes here:
- Support for correctly propagating case sensitivity. Please the correct types here (
TRUE
andFALSE
) - Remove authentication for reading the pubkeys. This looks correct. However, please remove those lines completely and indent the following line correctly.
from opensc.tokend.
Ok. I will clone OpenSC (though maintaining this clone us the last thing I need).
Regarding (1), it's the exact copy of the existing code a hundred of so lines down In the same file. Why is assignment to logical expression is good enough there but not here? And if it's bad, why not refactor that part? I thought you wanted the code to look uniform?
Regarding (2) - will do.
from opensc.tokend.
Related Issues (13)
- OpenSC.tokend cannot PIN-unlock a PIV card HOT 8
- can't see my italian CRS/CNS in 10.10 keychain HOT 6
- Mac OS X Yosemite Problem HOT 8
- Current sha2 branch lost the ability to RSA-sign HOT 3
- PIN Code gets rejected when trying to logon to an Active Directory Domain HOT 6
- PIN not recognized with Gemalto Prox-DU reader HOT 6
- With Mac OS X 10.11.5 tokend does not work any more HOT 8
- epass2003 tokend MacOS 10.12 HOT 4
- ccccccejjfcudkhcelvhbbecrhujgljbjgjkclbfvtti HOT 2
- MacOS Xcode-10 tokend fails to build HOT 13
- tokend does not work any more HOT 9
- xcodebuild on OSX 10.10 fails with unwanted "register launch services" HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opensc.tokend.