Giter Club home page Giter Club logo

Comments (2)

frankmorgner avatar frankmorgner commented on July 26, 2024

The PR mechanism is entirely designed around this feature 😉, please use it! PRs are best for quick integration and quick feedback/comments.

Also, I see two changes here:

  1. Support for correctly propagating case sensitivity. Please the correct types here (TRUE and FALSE)
  2. Remove authentication for reading the pubkeys. This looks correct. However, please remove those lines completely and indent the following line correctly.

from opensc.tokend.

mouse07410 avatar mouse07410 commented on July 26, 2024

Ok. I will clone OpenSC (though maintaining this clone us the last thing I need).

Regarding (1), it's the exact copy of the existing code a hundred of so lines down In the same file. Why is assignment to logical expression is good enough there but not here? And if it's bad, why not refactor that part? I thought you wanted the code to look uniform?

Regarding (2) - will do.

from opensc.tokend.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.