lua tcp socket read timed out about lua-resty-redis HOT 7 CLOSED

@djhalaninext Your code has a great risk of entering an infinite tight loop (thus maxing out CPU without doing anything good) when the read_reply() returns an error other than "read timeout", like "close" (when redis closes the connection prematurely). Always be VERY careful about while true loops.

from lua-resty-redis.

@djhalaninext Also, set_keepalive puts the underlying connection into the connection pool and shuts down the current resty.redis object and I don't think you want that upon every loop iteration. Better read the official documentation more carefully.

from lua-resty-redis.

@djhalaninext Another thing is that it's better to put require() on the top level of your Lua module instead of calling it everytime your function is called. require cannot be JIT compiled and it does not make sense to call it over and over again.

from lua-resty-redis.

@djhalaninext Always handle the errors of those resty.redis calls carefully in Lua, including set_keepalive and read_reply.

from lua-resty-redis.

@djhalaninext For redis subscribing, it's normal to get the read timeout error, which is not fatal at all. You just need to try read_reply again on the same resty.redis object. But as I've mentioned above, you MUST handle any other errors explicity without retrying read_reply blindly over and over again. Because for other fatal errors, any subsequent read_reply call will always return the "closed" error immediately, leading to hot tight looping in your example.

from lua-resty-redis.

@djhalaninext BTW, please use the openresty-en mailing list for such general discussions instead. Thank you for your cooperation! Please see http://openresty.org/#Community

from lua-resty-redis.

@agentzh Thanks for all the input. Will fix and post more questions in openresty-en mailing list.

from lua-resty-redis.