Giter Club home page Giter Club logo

Comments (3)

tfmorris avatar tfmorris commented on May 13, 2024

From iainsproat on May 12, 2010 19:40:42:
Updated patch attached. With further tests along the same line as before.

I've started adding guard statements to functions, throwing IllegalArgumentException if
a parameter is null.

Also noticed that some of the code in Command.getEngine was a duplicate of
Command.getEngineConfig, so I've refactored the former to call the latter.

from openrefine.

tfmorris avatar tfmorris commented on May 13, 2024

From iainsproat on May 12, 2010 22:17:30:
More tests (21 in total), and a bit more error catching and some slight refactoring.
This supersedes the above patches.

from openrefine.

tfmorris avatar tfmorris commented on May 13, 2024

From [email protected] on May 13, 2010 00:55:19:
Applied in r744. Looks good Iain, my suggestion is to just commit in the tree whatever new test you come up
with, I'll watch over your shoulders from there (commit then review is a lot more effective than review than
commit once we get things going)

from openrefine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.