Giter Club home page Giter Club logo

Comments (8)

BrianLang avatar BrianLang commented on July 17, 2024 1

Great, thanks a lot, also for the added info in the issue description!

from mmrm.

danielinteractive avatar danielinteractive commented on July 17, 2024 1

Maybe it should be a print instead of a show method for the S3 object here actually. I think it would be nice so that when the user just looks at the fitted object without saying summary then they get a meaningful representation instead of a very long list being printed on the console.

from mmrm.

BrianLang avatar BrianLang commented on July 17, 2024

I'd take this issue. Can you assign it to me?

from mmrm.

danielinteractive avatar danielinteractive commented on July 17, 2024

Awesome, thanks @BrianLang ! I just added you as a collaborator. Please let me know if any questions. I will also add you to our standup meetings and Slack channel for communication.

from mmrm.

BrianLang avatar BrianLang commented on July 17, 2024
  • see how other packages are doing it, e.g.:
    • glmmTMB: will look at this soon.
    • lme4: for lmList4 they use show to print out a model summary (coded within the function body), for merMod they first spec a S3 print method, and then call that in the S4 show method body. The difference seems to be that lmList4 inherits the print method from lme objects from the nmle package.

I see that we already have a print.summary method for mmrm objects, do we want a print method as well as a show? Kind of unclear as to when I'd want each of them. I don't think I've used show() before.

from mmrm.

danielinteractive avatar danielinteractive commented on July 17, 2024

Thinking about it more let's do it also here on the lower level mmrm_tmb object, and then this is inherited by the mmrm object. I added a few more detail ideas to the description.

from mmrm.

BrianLang avatar BrianLang commented on July 17, 2024

Okay, let's make an S3 print.mmrm_tmb and I'll use the approaches in the h_print_* methods.
Are those methods, which are used in print.summary.mmrm, presenting the output in the way you'd like for the base print.mmrm_tmb method?

  • see how other packages are doing it, e.g.:
    • glmmTMB: glmmTMB uses print.glmmTMB to present their objects, with the typical model output that one would expect. Very similar to what you've spec'd in the issue description.

from mmrm.

danielinteractive avatar danielinteractive commented on July 17, 2024

Cool, yeah that format should be fine, but feel free to propose modifications, thanks Brian for working on this!

from mmrm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.