Plus operator overloading about openmx HOT 6 CLOSED

@mhunter1, @RMKirkpatrick I need help on finalizing the pull request, I was about add a test unit for the PR, but I noticed that if i add:

`+.MxModel`  <- function (e1, e2) { 
  mxModel(e1, e2)
}

to MxModel.R, then build with make install and then run my tests, the new overloading is not being picked up and the test errs. Am I adding that code to the wrong place?

My test file looks like the following:

library(OpenMx)
library(testthat)
context("Plus operator")


mb <- mxModel("bivariate Heterogeneity Path Specification",
  type = "RAM",
  manifestVars = c("X", "Y")
) +
  mxPath(from = c("X", "Y"), arrows = 2, free = T, values = 1, lbound = .01) +
  mxPath(from = "X", to = "Y", arrows = 2, free = T, values = .2, lbound = .01) +
  mxPath(
    from = "one", to = c("X", "Y"), arrows = 1, free = T, values = c(0.1, -0.1),
    ubound = c(NA, 0), lbound = c(0, NA)
  )

mb <- mxGenerateData(mb, nrows = 1000, returnModel = T)
out <- try(mxRun(mb))

omxCheckEquals(is(out, "try-error"), FALSE)

The error:

from openmx.

On a second thought, I remember in R one needs to export a new function in order to be available to the user, otherwise it is just for internal use, is that it?

from openmx.

On a second thought, I remember in R one needs to export a new function in order to be available to the user, otherwise it is just for internal use, is that it?

Yes, I think you'll need to add the appropriate line to the NAMESPACE file.

from openmx.

Ok, done.

Will move on to #351 and then back. Thanks for the help.

from openmx.

You can also use roxygen to document, handle the namespace etc. in-line. Some OpenMx functions use this, most hand-write it all. It's a bit of a doctrinaire issue :-)

This is a stub I use, but you can learn more by searching #' in the code or https://roxygen2.r-lib.org

#' TITLE
#'
#' @description myfunc is a function which
#'
#' @details If any
#'
#' @param param a something to DO WHAT?
#' @return - what i return
#' @export
#' @family
#' @Seealso - [omxSimilarFunction()]
#' @references - if any
#' @md
#' @examples
#' myfunc(param)
#' \dontrun{
#'
#' }

from openmx.

from openmx.