Remove Geometry requires from vector formats about ol2 HOT 6 CLOSED

That's more responsibility for the application developer but that sounds good to me.

from ol2.

I think more interesting to follow the current requirements, but allows to build compressed code as proposed in http://trac.osgeo.org/openlayers/ticket/3496

This is what I use in production, e.g. to remove required features as OpenLayers/Tween.js in maps without controls
(But the programmer must ensure that the resulting code works e.g. without Tween currently it requires a dummy as OpenLayers.Easing={Expo:{easeOut:null}};)

from ol2.

I think I would distinguish between 'real' requires (meaning, code won't function without it) and 'optiional' requires (code will function ok as long as you don't try and use a function that needs that class). I think the requires instructions for the build program should be limited to the former - stuff that really is required. The formats are clearly the latter case - if you only have point data, there is no requirement for LineString, Polygon etc: the code works perfectly well without them. I think the optional requires should be written up in the docs, so people know what to include in their build config.

There are quite a few inconsistencies at present, for example, with the Formats, WKT has no requires of geometries at all. I would propose standardising this, to the lowest common denominator.

from ol2.

Yes I agree (sometimes I think too much in the inexperienced user, sorry, is best to minimize @requires, but ticket/3496 is designed for the experienced user)

To fix some inconsistencies would be nice to have the clause @include as in jstools
(e.g. OpenLayers/BaseTypes/Bounds.js fails without OpenLayers/Utils.js, but do not have @requires OpenLayers/Utils.js to avoid circular requires, and more... I'm not OpenLayers team and I can do little in this way, sorry)

In WKT did not requires geometries to avoid a circular inclusion, because geometry requires WKT. I think currently (after SHA: 66de55e) it should be added @requires OpenLayers/Geometry/Point.js in WKT

from ol2.

hm, I'm no longer so sure about this. I realised when changing Format/KML that you don't necessarily know at build time what geometries are going to be needed, for example if you're reading someone else's data - even if you're only interested in the point data in, say, a kml file, if the file contains other geometry types the read will fail. You could put in checks for each geometry type whether the actual class is present, but that seems more trouble than it's worth.

So perhaps it's better to leave the geometry requires in there as the default and use the excludes section for those situations when you know you are only dealing with particular geometries (or, of course, don't use the build system :-) ).

from ol2.

ok, as 'excludes' works well, I've convinced myself that it's better to stick with the existing situation.
Issue closed

from ol2.