Giter Club home page Giter Club logo

Comments (8)

lgritz avatar lgritz commented on July 17, 2024

I don't suppose you can supply a small example image? I bet this is easy to track down and fix.

from oiio.

rexbron avatar rexbron commented on July 17, 2024

Absolutely!

Reference Image: http://files.aehunter.net/oiio/Chasing_Master_8bit_Rec709_04321.tif

DCDM: http://files.aehunter.net/oiio/Chasing_Master_12bit_XYZ_04321.tif

Let me know if you need more information.

Cheers!

from oiio.

lgritz avatar lgritz commented on July 17, 2024

I have a fix for this. I'm not sure how to link this ticket with a specific pull request. Does anybody else know?

from oiio.

lgritz avatar lgritz commented on July 17, 2024

By the way, even after implementing the fix, I am not seeing the images match. Should I infer from the names of your files that the DCDM one is in "xyz" space and therefore is not expected to be a visual match for the Rec709 one?

from oiio.

rexbron avatar rexbron commented on July 17, 2024

Hey Larry,

You are correct, the image data won't match as the second (12-bit) image is in xyz space. I can try and find a 12 bit tiff that hasn't had that transform applied.

Cheers!

from oiio.

lgritz avatar lgritz commented on July 17, 2024

No problem, I have other test images (including many from libtiff's official test collection). I just wanted to be extra sure that any remaining difference between the two example images you sent were intentional, and not indicating that there were still bugs.

Thanks for the examples and filing the issue -- I actually appreciate the opportunity to beef up our handling of the oddball bit depths.

from oiio.

lgritz avatar lgritz commented on July 17, 2024

The pull request for this is #168 #168

from oiio.

lgritz avatar lgritz commented on July 17, 2024

Long since fixed.

from oiio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.