Giter Club home page Giter Club logo

Comments (3)

dingran avatar dingran commented on August 14, 2024 1

yeah, I think it'd be good to maybe consolidate the two; i see example.py still uses the older version

also in the new version you can get rid of the cuda cache vectors?
https://github.com/ZrrSkywalker/LLaMA-Adapter/blob/fd4fb6cb8f947c941c5ec3b9dd6342b4a06ed727/alpaca_finetuning_v1/llama/model.py#L84-L85

from llama-adapter.

csuhan avatar csuhan commented on August 14, 2024

Thanks for pointing out this bug!

The model in llama/model is an early version of LLaMA-Adapter,
https://github.com/ZrrSkywalker/LLaMA-Adapter/blob/fd4fb6cb8f947c941c5ec3b9dd6342b4a06ed727/llama/model.py#L151

while the model in alpaca_finetuning_v1/llama/model is an updated version. We use tanh to limit the range of gate.
https://github.com/ZrrSkywalker/LLaMA-Adapter/blob/fd4fb6cb8f947c941c5ec3b9dd6342b4a06ed727/alpaca_finetuning_v1/llama/model.py#L121

Anyway, we should use the same format of gate in both training and inference.

from llama-adapter.

csuhan avatar csuhan commented on August 14, 2024

Thanks for your suggestions. We will clean it soon.😀

from llama-adapter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.