copying to system/vendor not allowed when building separate vendor partition about aosp_build HOT 8 CLOSED

no, no progress from me yet.

I will try to find some time next week to look at this.

from aosp_build.

@Blystad , @mfonville : thanks for your comments and the pointer to #63.

I will open a PR in the next few days to address this.

As I mentioned before (in a different thread), rather than using the file vendor/google/build/config.mk, I'd like to try incorporating opengapps into the build in a different way. This should alleviate the problems we see with build variables not being defined. If I can't get that to work, then I will resort to calling get_build_var / get_abs_build_var as suggested above :-)

from aosp_build.

We have fixed this locally by skipping the pittpatt copy statements when the device is bullhead (those files actually get copied to the vendor image by a statement in a separate part of our in-house build).

But rather than using a device-type check, what we should really be doing is checking whether a vendor image is being built (and then generating different PRODUCT_COPY_FILE statements).

Inside the "build" project, the statement ifdef BOARD_VENDORIMAGE_FILE_SYSTEM_TYPE is used to check whether a vendor image is being built, but that doesn't work inside vendor/google/build/opengapps-files.mk because of the way the opengapps makefiles are included in the build system; they are processed before device/lge/bullhead/BoardConfig.mk.

from aosp_build.

I tried fixing this with #65 but that didn't work, because of how stuff is processed.

See original issue #63

The project I build doesn't have a vendor/ partition, so it's a bit difficult for me to test. I would welcome PRs that fixes this issue, since this seems to be a recurring issue.

You could try get_build_var and get_abs_build_var (from source/buildenv.sh), maybe that'll get the value necessary.

from aosp_build.

A short addendum: in Nougat the libfrsdk.so seems to have moved from /vendor to the directory of the facelock apk itself, and pittpatt has been removed;
I still have to incorporate those changes, but it seems that over time this issue will resolve itself and system related stuff will not be put on that partition anymore.

from aosp_build.

@jamuir any updates here?

from aosp_build.

@Fuzion24: I have a branch that should resolve this, but I haven't tested it yet. You are welcome to give it a try:

https://github.com/GraphiteSoftware/aosp_build/tree/jm-system-vendor

from aosp_build.

fix has been merged.

closing.

from aosp_build.