Comments (2)
It is indeed a grey area of the LRS specification, and I understand that it can be a pain to work around it.
I think removing the duplicate statements from the batch and continue processing would be a logic thing to do.
I think it would require to implement a deep comparison of statements to cover the following cases:
- If LRS receives a statement with an ID it already has a statement for, and statements don't match: don't do anything, return a
409 Conflict
- if LRS receives a statement with an ID it already has a statement, and statements match: remove statement from batch and continue posting the batch.
This deep comparison would come with a performance cost (at least until pydantic v2 is out 🔜), but would be mitigated by only checking the duplicate ids.
However, I'm not so sure about adding the found duplicates into the response details, as we already return the array of statements that has been posted. What would you suggest?
from ralph.
I think the deep comparison would be good once it can be done, though even that is complicated in the spec since some fields should not be considered in the comparison. I forgot that the array of statements was returned, that is totally sufficient!
from ralph.
Related Issues (20)
- (api) Make code tidier by replacing scopes as strings
- Replace Python linters with Ruff
- Support Python 3.12
- Remove JSON column from ClickHouse backend HOT 1
- Rewrite contributing section in documentation
- Switch from setup.cfg to pyproject.toml
- Add "# TODO" check to linting
- Ensure testing of `count` as result of `write`, for all backends. HOT 1
- Fix `www-authenticate` header HOT 1
- Modifying `settings` on a DataBackend does not update `client`
- [Clickhouse]Look into removing use of both `statementId` and `statement_id` in queries
- [pydantic >2] Replace deprecated `parse_obj_as`
- [Pydantic > 2] Replace for loop in `factory.py` model generation HOT 1
- [pydantic > 2] xAPI extensions cannot hold empty strings
- [pydantic > 2] [API] Fix `IRI` typing of `verb` and `activity` queries in `get`
- [pydantic > 2] [api] Add URL validation to `openid` field
- [backends] [clickhouse] Look into removing redundency of `statement_id` and `statementId`
- [pydantic > 2] [tests] [polyfactory] Remove custom value for `course_id`
- Rename LDP `DEFAULT_STREAM_ID` setting to `STREAM_ID` HOT 1
- Scaled score is typed as int HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ralph.