Add support for non-destructive value addition about openfoodfacts-dart HOT 10 OPEN

We created that when we didn't have efficient editing, and also for offline editing (where tags on server might - 5% chance - have changed). It's more of a safety measure than anything else, but if you retrieve existing values, show them to the user, let them edit them, and send everything, we do not need them (assuming that the last user who speaks is right)

from openfoodfacts-dart.

It might be useful for other apps, but I'd rather have destructive editing for Smoothie (the whole point of the tag picker)

from openfoodfacts-dart.

@teolemon I guess once this implemented I should rollback my changes here ? #128

Otherwise writing labels, categories with saveProduct() will delete the previous values and keep only the last input

from openfoodfacts-dart.

@MohamedFBoussaid What's the current behavior ? We could have both ways, a full replace or a patch solution ?
add_ has some limitations as well (it does not allow for precision editing)

from openfoodfacts-dart.

I suggest a new method like this one:

static Future<Status> OpenFoodAPIClient.addToProduct(
    User user,
    Product product,
    Map<AddableField, String> addedValues, {
    QueryType queryType = QueryType.PROD,
  })

with AddableField being an enum (BRANDS, LABELS, CATEGORIES, ...)
That would have no impact on @MohamedFBoussaid's code.
@teolemon Would that suit your needs?

from openfoodfacts-dart.

@teolemon Would that suit your needs?

I think it would. I think editing the product is the main behavior we want to keep as a default here. @teolemon any thoughts?

from openfoodfacts-dart.

Yeah lets do it like that

from openfoodfacts-dart.

@VaiTon Any idea about the list of addable fields? Will they all be accepting String as value?

from openfoodfacts-dart.

@VaiTon Any idea about the list of addable fields? Will they all be accepting String as value?

I think every field has an 'add' version except from code and lang. (From here https://wiki.openfoodfacts.org/API/Write)

Yes, everything can be sent as a string.

On android we have atm:

const val ADD_BRANDS = "add_brands"
const val ADD_PURCHASE = "add_purchase_places"
const val ADD_STORES = "add_stores"
const val ADD_COUNTRIES = "add_countries"
const val ADD_TRACES = "add_traces"

from openfoodfacts-dart.

@teolemon The way I understand your comment, you mean that this issue is pointless, should be closed and that the related PR should be ignored, am I right?

from openfoodfacts-dart.