Comments (3)
I understand your thoughts, if the api specifies it as unknown, it would be logical to write it in the enums as well, but does it make such a big difference that it is worth changing it?
Or do you mean that we should use maybe and unknown
from openfoodfacts-dart.
There should be both maybe
and unknown
elements.
For example: enum VeganStatus { IS_VEGAN, IS_NOT_VEGAN, MAYBE, UNKNOWN }
The difference between maybe
and unknown
could be significant for some kinds of applications. For example:
- When a product has
unknown
vegan status, that means that 1+ of its ingredients have unknown vegan status - such ingredients either are not in theingredients.txt
file yet, or their vegan status there is not specified yet. - When a product has
maybe
vegan status, that means that 1+ of its ingredients havemaybe
vegan status - such ingredients are present in theingredients.txt
file and their vegan status is explicitly specified asmaybe
(or is inherited from parent ingredient type), which means that they could be both vegan and non-vegan, the actual status depends on how the ingredient from a concrete product was manufactured.
from openfoodfacts-dart.
I agree, we should have both "maybe" and "unknown".
from openfoodfacts-dart.
Related Issues (20)
- Create MatchedScoreV2 and deprecate MatchedProductV2
- Different user agent for tests
- Add support for the weigh facet HOT 1
- User should be optional in get random robotoff questions HOT 1
- Robotoff refactoring HOT 7
- Refactor: get rid of path.dart dependency
- Autosuggest works erratically if the responses are not received in the right order HOT 5
- Add capacity to know which fields are producer provided HOT 1
- Add the ability to remove a translation in a multilingual field
- Refactoring from smoothie (KP element)
- Make the link between raw data and computed data visible
- Update HTTP Library HOT 7
- Implement Robotoff nutrition prediction route HOT 2
- Allow to fetch robotoff questions by insight_type for a given product HOT 3
- Match the latest Robotoff question and insight API HOT 1
- Robotoff: add the "server type" parameter (off, obf, ...) HOT 5
- Implement the new account deletion undocumented API HOT 2
- Product.dart does not convert packagings correctly to JSON HOT 3
- Allow to change the host for the sign-up
- Add Smoothie play/app store links to readme HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openfoodfacts-dart.