Support for Log4j/Slf4j Logger about feign HOT 14 CLOSED

sounds fine to me. just make tiny new modules for each.

from feign.

I had been considering adding those sorts of loggers in my company's feign-extensions module. I don't have an objection to inclusion in the main repo, but I don't see any particular reason every little thing needs to be in one repo on one release cycle either.

from feign.

fair concern. personally, I think we would get more mileage out of special-casing slf4j than a blanket adding both.

from feign.

Also, in practice there are MDC variables that could be set in either slf4j or log4j to help manage log appenders.. should think about that.

from feign.

I'm going to be circling back to this tomorrow morning. I expect the result will be a pull request with the addition of an SLF4J module to the main feign repo. I don't really see the point in a Log4j module; if you're using Log4j as your logging backend, in 98% of the cases the SLF4J logging module will work just fine. In those rare other cases, you're probably better off using a custom logging module rather than an off-the-shelf Log4j module anyway.

from feign.

Sgtm

from feign.

It looks to me like the slf4j support was implemented for 6.1.0 (and that's what the changelog currently says) but it wasn't actually merged into the 6.x release branch or included in the 6.1.1 or 6.1.2 releases. @allenxwang, could you please take a look?

from feign.

@davidmc24 It looks like it didn't make it into the 6.1.3 release either...can we expect this to be released sometime soon?

from feign.

I have no control over the release process... or visibility into it, either.

from feign.

@davidmc24 Are you releasing feign or publishing it? We could commit a change to allow a different maven group id, so that development can continue on your (or someone else's) fork until/unless this line progresses.

from feign.

I don't believe my company currently has any internally published feign builds. As I recall, this was the last contribution I made, and all of our projects using feign already had a feign-slf4j logger in their source trees, so there wasn't any particular urgency.

from feign.

Ah, ok. Just seems a little sloppy to describe functionality in the readme that hasn't actually been released yet. Not sure who to talk to about that.

from feign.

Hi ~
When would you register this for maven ?
I can't find this in maven repository now.

from feign.

this is in 7.0.0

from feign.