Support Basic Authentication about feign HOT 5 CLOSED

I think basic auth is slim and common enough for core. @andreaturli asked about this iirc

from feign.

+1

from feign.

Cool, I'll put together a pull request in the next couple days.

Until then, here's the quick-and-dirty version that I'm currently using. It was implemented before Feign.Builder was introduced (and thus, any interceptors needed to be part of a Dagger module to be used), and was implemented in the context of a Grails project (thus making the assumption of Groovy being present a safe one).

https://gist.github.com/davidmc24/6666237

I expect the submitted version will be very similar, but with the base64 encoding and charset logic getting pulled into Util rather then adding new dependencies.

from feign.

ps mildly prefer sun.misc.BASE64Encoder as all jdks I've run into retain
support

On Sun, Sep 22, 2013 at 8:42 PM, David M. Carr [email protected]:

Cool, I'll put together a pull request in the next couple days.

Until then, here's the quick-and-dirty version that I'm currently using.
It was implemented before Feign.Builder was introduced (and thus, any
interceptors needed to be part of a Dagger module to be used), and was
implemented in the context of a Grails project (thus making the assumption
of Groovy being present a safe one).

https://gist.github.com/davidmc24/6666237

I expect the submitted version will be very similar, but with the base64
encoding and charset logic getting pulled into Util rather then adding new
dependencies.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/79#issuecomment-24897644
.

from feign.

Re: sun.misc.BASE64Encoder
Okay, I can do that. If such a JDK ever appears, we can fix it then.

from feign.