Giter Club home page Giter Club logo

Comments (5)

dinomite avatar dinomite commented on May 15, 2024

Re: Feign's own Logger implementation…would it be a worthwhile undertaking to replace that with slf4j? It'd be much nicer to have request logging work in a standard way, rather than it all being one level via the existing feign-slf4j.

from feign.

kdavisk6 avatar kdavisk6 commented on May 15, 2024

The set up today in Feign is to provide simple, basic implementations in feign-core to keep the dependencies light and allow developers to plug in as they go. It's the price we pay for extensibility.

However, if there is enough interest in this and in making feign-core more general use, we can certainly look into it.

from feign.

spencergibb avatar spencergibb commented on May 15, 2024

I'd prefer tracing not be in core

from feign.

dinomite avatar dinomite commented on May 15, 2024

I created #738 to describe what I was really getting at.

from feign.

kdavisk6 avatar kdavisk6 commented on May 15, 2024

https://github.com/OpenFeign/feign-opentracing looks to be a good solution for this.

from feign.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.