interface level header defaults about feign HOT 9 CLOSED

from feign.

from feign.

yeah, that's good too. How would you set the media type for that interceptor?
some like:

Feign.builder().requestInterceptor(new RequestMediaTypeInterceptor("application/json"))

or like

Feign.builder().contentType("application/json") // under the covers add the interceptor?

or did you have something else in mind?

from feign.

from feign.

I linked to a commit ^ - before i spend too much more time i wanted to see if this was more inline.. (i'm sure some naming might need tweaking)

from feign.

Looks good! One nit would be to adjust the javadoc on Headers to suggest that they are additive, so don't place anything on the type that isn't meant for all methods. That and a test case that shows this. (ex. adding the same header twice = 2 values). Good job, Jeff!

from feign.

oof.. @jdamick we have a hitch. My intention is that 8.x is feature compatible with 7.x. That way, folks can migrate cleanly off dagger via the 7-8 bridge. Also, Spring implement Contract. We probably want to avoid changing the Contract interface as a part of this change.

What that means is that we'd need some logic to reach up to the type in parseAndValidatateMetadata to find the base headers. Ex.

Headers fromType = method.getDeclaringClass().getAnnotation(Headers.class);

Ack that is more expensive than your approach. Wdyt about saving Contract interface refactors for when we bang our heads around hystrix/rxnetty?

from feign.

I have no burning need for it at the moment, so i'm fine with waiting until 9.

from feign.

added to 7.4/8.1 release after realizing a simple way to accomplish this portably.

from feign.