Giter Club home page Giter Club logo

Comments (8)

codefromthecrypt avatar codefromthecrypt commented on May 15, 2024

@allenxwang @cfieber ping!

from feign.

allenxwang avatar allenxwang commented on May 15, 2024

The next version should be 6.0.2. Correct?

Also see build errors when trying to release 6.x branch. The error is

* What went wrong:
Could not resolve all dependencies for configuration ':feign-example-github:compile'.
> Could not find com.netflix.feign:feign-core:5.0.0.
  Required by:
      com.netflix.feign:feign-example-github:6.0.2
> Could not find com.netflix.feign:feign-gson:5.0.0.
  Required by:
      com.netflix.feign:feign-example-github:6.0.2

from feign.

davidmc24 avatar davidmc24 commented on May 15, 2024

If you're including all the pending changes (#97, #96, and #92), I would expect the next version should be 6.1.0, as new features have been added, but they're backwards-compatible. If we're going with that version, we should adjust the changelog to indicate that what's currently noted as 6.1.1 is actually part of 6.1.0. I can provide a pull request in that direct if desired.

Building from the current head of the 6.x branch, I don't see that error. My guess is that the difference is due to the build tweaks that take place as part of netflix-oss.gradle. The referenced artifact does exist in Maven Central.

from feign.

allenxwang avatar allenxwang commented on May 15, 2024

@davidmc24 The latest version I found in maven is 6.0.1. Is my understanding correct that we need to bump the version string to 6.1.1 in gradle.properties in 6.x branch before we can release 6.1.1?

from feign.

davidmc24 avatar davidmc24 commented on May 15, 2024

Yes, a bump to the version in gradle.properties in the 6.x branch will be needed.

from feign.

allenxwang avatar allenxwang commented on May 15, 2024

Release build is successful and sonatype repository is released.

from feign.

mohitsoni avatar mohitsoni commented on May 15, 2024

Thanks guys!

from feign.

codefromthecrypt avatar codefromthecrypt commented on May 15, 2024

Thanks, Allen!

from feign.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.