Comments (9)
The idea here is that we can garbage-collect or remove functions when we're sent an event from GitHub saying someone uninstalled the GitHub App.
Let's say I install OF-Cloud on RepoA and RepoB - both contain 5 functions each totaling 10.
Now I remove the app from RepoA, the event sent to us should inform us to remove any functions with matching metadata showing they came from RepoA for that user.
from openfaas-cloud.
Is someone currently working on this?
from openfaas-cloud.
Not to my knowledge.
from openfaas-cloud.
I already started to research the API. If the change is not ASAP change can i take the issue?
from openfaas-cloud.
I think that'd be fine. Can you size it up and write your estimation here first?
from openfaas-cloud.
I think in two or three days I will be ready with the change. Need time to check the API and how the code uses other existing functions.And I need to learn how to test the cloud efficiently so mainly my time will go in that direction.
from openfaas-cloud.
OK so can you summarise the discussion we had on Slack? I think you said github-event is already doing the work needed?
from openfaas-cloud.
Sure currently installation alone does not provide enough info for build and deploy, but it provides enough for the garbage-collect on application removal which was already done.
from openfaas-cloud.
Derek close: Discussed that the API does not provide enough information for the function to be built unless we have another API call and that the current implementation for how you "install" works. Garbage collect is supported on removal event.
from openfaas-cloud.
Related Issues (20)
- Feature: support cloudflare integration HOT 3
- GitHub events time out with network policy
- minor doc tidy HOT 3
- Add CI variable to git-tar
- Deprecate passing Oauth client secret in environment for OFC chart
- Make Network Policies optional in OFC chart
- Remove redundant `global.scheme` from ofc helm chart
- Migrate from Travis to Github Actions
- Migrate go Go Modules
- Implement all openfaass cloud components in the Helm chart
- Use GHCR in helm chart
- Build remaining images for AWS and GitLab YAML files HOT 1
- Dashboard image missing bundled assets HOT 1
- Link to GitHub app from dashboard HOT 5
- [Feature request] Support GitLab container registry HOT 1
- [Feature request] Support GitLab group as functions' owner in dashboard HOT 1
- system-metrics on the dashboard is showing 0 HOT 3
- Docs: Update user-guide to newer template
- failed to deploy functions using openfaas operator HOT 4
- Pipeline not triggered: gitlab-event: System Hook required cannot handle: Tag Push Hook HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openfaas-cloud.