Giter Club home page Giter Club logo

Comments (9)

alexellis avatar alexellis commented on August 16, 2024

The idea here is that we can garbage-collect or remove functions when we're sent an event from GitHub saying someone uninstalled the GitHub App.

Let's say I install OF-Cloud on RepoA and RepoB - both contain 5 functions each totaling 10.

Now I remove the app from RepoA, the event sent to us should inform us to remove any functions with matching metadata showing they came from RepoA for that user.

from openfaas-cloud.

martindekov avatar martindekov commented on August 16, 2024

Is someone currently working on this?

from openfaas-cloud.

alexellis avatar alexellis commented on August 16, 2024

Not to my knowledge.

from openfaas-cloud.

martindekov avatar martindekov commented on August 16, 2024

I already started to research the API. If the change is not ASAP change can i take the issue?

from openfaas-cloud.

alexellis avatar alexellis commented on August 16, 2024

I think that'd be fine. Can you size it up and write your estimation here first?

from openfaas-cloud.

martindekov avatar martindekov commented on August 16, 2024

I think in two or three days I will be ready with the change. Need time to check the API and how the code uses other existing functions.And I need to learn how to test the cloud efficiently so mainly my time will go in that direction.

from openfaas-cloud.

alexellis avatar alexellis commented on August 16, 2024

OK so can you summarise the discussion we had on Slack? I think you said github-event is already doing the work needed?

from openfaas-cloud.

martindekov avatar martindekov commented on August 16, 2024

Sure currently installation alone does not provide enough info for build and deploy, but it provides enough for the garbage-collect on application removal which was already done.

from openfaas-cloud.

martindekov avatar martindekov commented on August 16, 2024

Derek close: Discussed that the API does not provide enough information for the function to be built unless we have another API call and that the current implementation for how you "install" works. Garbage collect is supported on removal event.

from openfaas-cloud.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.