Break out proxying code from all providers about faas-provider HOT 12 CLOSED

I can work on this

from faas-provider.

This is a very big task. Do you think there is a part up you could without committing to it all?

from faas-provider.

Derek add label: size/xxl

from faas-provider.

As a start point I can move faas-swarm proxy code here and test on Swarm with faas-provider.

After having this, the work can be separated on those steps/issues:

Step 2: Make refactoring to merge faas-netes and openfaas-operator proxy in a separate package and test both using faas-provider. This is before step 3, as they are similar and safer to merge together.

Step 3 (advanced): Make refactoring to merge swarm and kubernetes proxy

from faas-provider.

Derek assign: me

from faas-provider.

I noticed an implementation detail in faas-swarm, you can specifiy the function name via the X-Function header

https://github.com/openfaas/faas-swarm/blob/6c10aa50f711139ec79bffbe938b2e2d366e3dc1/handlers/proxy.go#L55

But this doesn't exist in either k8s implementation

https://github.com/openfaas/faas-netes/blob/5dadd402921554fd846be8fdd97cf79c9a7ad9fc/handlers/proxy.go#L21

I noticed in the faas repo that there is a test that notes the implementation is being deprecated

https://github.com/openfaas/faas/blob/28c9ccd0aa4f1de7b00e919b4d140fdd1eaf1aa7/gateway/tests/integration/routes_test.go#L106

Can I remove it from this implementation?

from faas-provider.

Hi @LucasRoesler I don't believe anyone is using X-Function, feel free to deprecate it and if we find it's important for users we can reinstate.

from faas-provider.

The X-Function behavior was removed #11

from faas-provider.

Can this issue be closed? @LucasRoesler

from faas-provider.

Unfortunately, no. This was applied two faas-swarm in openfaas/faas-swarm#39

But faas-netes is not using the faas-provider proxy yet

from faas-provider.

How are we doing with this now? @LucasRoesler

from faas-provider.

faas-netes now uses the provider, as of this commit openfaas/faas-netes@c1ba865 4 months ago

the operator is using the provider as of this commit https://github.com/openfaas/openfaas-operator/commit/156e27eac06d1db38c977ddcb41de07f45453a17 2 months ago

I thinik this means we can close this

from faas-provider.