Giter Club home page Giter Club logo

Comments (2)

johnb30 avatar johnb30 commented on July 30, 2024

This already exists at https://github.com/openeventdata/petrarch2/blob/master/petrarch2/data/config/PETR_config.ini. Additionally, the deployed version of the pipeline has always specified a separate config file for PETR with the dictionaries living in a top-level directory. You can see how you'd hit that at https://github.com/openeventdata/petrarch2/blob/master/petrarch2/petrarch2.py#L530. The built in dictionaries are included so people can download and run as-is without having to hunt for dictionaries as well.

If this isn't clear in the documentation/user guides then it should be called out in greater detail. In other words, I think this is a docs issue rather than a feature issue.

from petrarch2.

philip-schrodt avatar philip-schrodt commented on July 30, 2024

But there's a bigger issue here that goes way beyond just the dictionaries: there's quite a bit of CAMEO-specific code in Petrarch-2, e.g. the fairly complex system by which certain word combinations modify the event code, then the conversion of the internal representation of the code to CAMEO via the utilities.convert_code() function. This was not the case in Petrarch-1, TABARI or KEDS, but was the case in the VRA-Reader and, as far as I know, ICEWS/Accent. Which is to say, the problem has been solved both ways.

My inclination (obviously...) is that the coder should be completely neutral to the coding system, but that's not what we've got at the moment in Petrarch-2, and getting there would require an extensive rewrite, and probably would best be done by adding some sort of macro facility to the dictionaries . That would be a "good thing" (TM) and TABARI came pretty close to having this, though it was never really used in working dictionaries, and Petrarch-2 already has a limited version as well.

Possibly the place to figure this out, however, is in deciding how the dependency-based version of the program is going to work.

from petrarch2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.