Using kadamski/arduino_sds011 library about sensors-software HOT 10 CLOSED

We need some parts of this code (start cmd, stop cmd, ...) in other scripts and sources. Here we have a place to look for them. Some users want to use the SDS011 on Raspberry Pis or other systems. I can't find these cmds in the mentioned source (okay, may be it's to late to look for something like this ...).

from sensors-software.

The commands are included in the Sds011.h. I use the library this way:

SoftwareSerial serialSDS(SDS_PIN_RX, SDS_PIN_TX, false, 128);
sds011::Sds011 sensorSDS(serialSDS);

void initSDS(){
  sensorSDS.set_sleep(false);
  sensorSDS.set_mode(sds011::QUERY);
  sensorSDS.set_sleep(true);
}

from sensors-software.

We need the serial data that ist sent to the SDS011 to start and stop. Not the library commands.
And as far as I can see, these commands are not "active" (CMD_SLEEP ist empty).

from sensors-software.

Alle the commands have values. It's a ENUM and they get their values implicitly by incrementing the previous value.

from sensors-software.

Okay, but our intention stays the same. Having the possibility to copy the binary command code to other "languages".

from sensors-software.

This will only clean up our code. The size of the firmware file or the used mem will stay nearly the same. This would only be another lib, where we have to look for changes on any update. We had a discussion about ArduinoJSON, where our code has thrown some warnings after an update. And one user told us, that our code is faulty and that he can't compile the firmware.

from sensors-software.

I don't see a valid reason for that. In other languages there are much easier ways to implement it than in C++.

• Python: http://www.codegists.com/snippet/python/sds011_kadamski_python
• Ruby: http://www.codegists.com/snippet/ruby/sds011rb_qoobaa_ruby
• other random language

from sensors-software.

see changes in last comment. WiFiManager is another lib we had to rewrite for our project even if for slightly other reasons.

from sensors-software.

In my opinion the current SDS011 code bloat your code and is hard to read and understand. What do you think about copying the library into your repository?

from sensors-software.

Sorry, the SDS011 code will be left there.
(160 out of 2300 lines of code)

from sensors-software.