Giter Club home page Giter Club logo

Comments (5)

tahamukhtar20 avatar tahamukhtar20 commented on August 17, 2024

@bsekachev What do you think about this one, can I work on this?

from cvat.

bsekachev avatar bsekachev commented on August 17, 2024

Hello,
Are you going to fix all typescript warnings in the product?
Or just enable linting? The second option will not really work well for people who deliver new features because they will also need to fix existing errors and warnings.

from cvat.

tahamukhtar20 avatar tahamukhtar20 commented on August 17, 2024

No @bsekachev, I think linting is already enabled, there are some typescript warnings in some files, I noticed these initially when I was working on my issue which was previously assigned to me, so the first option, fixing all typescript errors in the product.

from cvat.

bsekachev avatar bsekachev commented on August 17, 2024

Under linting I actually meant adding one more stage on git pre-commit (now it runs eslint on changed files, for example). But typescript must run for all the files, because if we change type in one file, it may easily affect many other.. And adding a new action on GitHub.

from cvat.

tahamukhtar20 avatar tahamukhtar20 commented on August 17, 2024

Yes, so there are some typescript warnings right now, for example, there are some types which are not added in the code, the code runs fine without those types but, it throws some warnings, =>
image
in this image we just need to add a return type which would be void in this case to remove the warning.
I'm looking to fix such errors and not add any new action on GitHub as that would cause problems for other contributors and their workflows.
So, @bsekachev should I work on this? Please let me know if this needs some more explanation.

from cvat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.