Comments (3)
I agree that we shouldn't have mixed system-address and local-port :(
It seems reasonable to add 'local-address', and require that both system-address (probably loopback-like) and local-address both be filled in, in the message.
Comments for the ports/protocols seem reasonable, yes.
As to channel-id, I was actually thinking (I believe) that this was the gRPC channel id:
https://grpc.io/docs/what-is-grpc/core-concepts/#channels
upon re-reading that, though, it looks like 'channel' is actually the whole of the connection :( not the sub path/channel I was expecting, and which I think does, actually, exist. So, removing channel-id seems safe.
from gnsi.
OK. #105 addresses the first two bits. I guessed at the intended meaning of the layer4_proto field.
from gnsi.
I am struggling with channel_id. It seems to be nonsense for gRPC, as a gRPC channel is not about multiplexing. gRPC does not appear to have any multiplexing abilities per-se; it is synchronous though.
For ssh, it would make sense (see https://datatracker.ietf.org/doc/html/rfc4254#section-5.1), but I can not think of reason that it would be relevant, except if one wanted to correlate accounting for each channel this could be the "receiver channel" from the struct mentioned in the rfc.
from gnsi.
Related Issues (20)
- authz: Clarity needed for few operations DURING Rotate() in progress HOT 3
- Certz does not have counters per-profile HOT 4
- gnsi.accounting.v1 SessionInfo.system_address HOT 2
- RecordResponse.ServiceStatus only applies to GrpcService
- Use of json for policy in authz without a protobuf alternative is obtuse HOT 2
- Clarity needed (in a comment) for acctz RecordRequest keepalives HOT 10
- certz default profiles HOT 3
- Inconsistency between documentation and protobuf definition for groups with members
- authz ProbeResponse action enum HOT 2
- pathz grpcurl reflection: included an unresolvable reference to ".gnmi.Path"
- Certz should permit delivery of a certificate bundle as a PKCS#7 encoded string.
- Version handling in credentialz.proto
- protoc-gen-go-grpc gRPC code generation plugin downgraded HOT 1
- Need a 'class/group' field in the user credentials
- Fix typo for pkcs7. HOT 1
- Certz: Need clarification on usage of ExistingEntity
- Certz: Need clarification on usage of ExistingEntity HOT 1
- gnsi.account missing telemetry HOT 1
- authz default behavior should not be vendor prerogative HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gnsi.