Giter Club home page Giter Club logo

Comments (7)

byg0n3 avatar byg0n3 commented on August 16, 2024

Not a big deal as 'Socketed Gems are Supported by %gem%' not implemented yet, but still.

from pathofbuilding.

Openarl avatar Openarl commented on August 16, 2024

I'm aware that there are still a lot of item affixes that aren't supported. The thing is, there is a HECK of a lot of them and many of them require special support, so I haven't yet had time to implement them all. Truthfully I'll probably never get all of them working; same goes for passive skills (particularly Ascendancy notables). I've mostly just been implementing them as people request them; Socketed Gems are Supported by X is a major one I've been looking into, but it's a tricky one to do. For now you can just add the support manually.

from pathofbuilding.

byg0n3 avatar byg0n3 commented on August 16, 2024

Yeah, I'm adding them manually right now.
But the thing is that if even they (affixes) are exists in your templates (like with Marohi), they does not import correctly.
It may affect other imports also. Above are just an examples that I've found so far.

from pathofbuilding.

Openarl avatar Openarl commented on August 16, 2024

Even though affixes like the Inc AoE support on Marohi aren't supported yet, they are still included in the items so that when I do add support they'll start working right away. I indicate which affixes are supported by showing them in blue, unsupported ones are white, so technically everything is working as designed.

from pathofbuilding.

byg0n3 avatar byg0n3 commented on August 16, 2024

Looks like you don't get my point or i can't explain it properly :D (And I guess that's about me, because english is not my native.)

Just try to paste the below item stats (for Marohi) into PoB and you'll see that there's no 'Supported by X' on imported (pasted) item.
That's I was talking about.

Rarity: Unique
Marohi Erqi
Karui Maul
--------
Two Handed Mace
Quality: +20% (augmented)
Physical Damage: 324-502 (augmented)
Critical Strike Chance: 5.00%
Attacks per Second: 0.99 (augmented)
--------
Requirements:
Level: 68
Str: 182
Int: 99
--------
Sockets: R-R-B-R-R 
--------
Item Level: 69
--------
20% increased Stun Duration on Enemies
--------
Socketed Gems are Supported by level 15 Increased Area of Effect
244% increased Physical Damage
Adds 10-20 Physical Damage
10% reduced Attack Speed
-100 to Accuracy Rating
10% reduced Movement Speed
45% increased Stun Duration on Enemies
--------
Lumbering as a sea lion, clumsy as a berry-drunk pigeon. That was Erqi. 
It mattered little. When Erqi's maul fell true, so did its target.

from pathofbuilding.

Openarl avatar Openarl commented on August 16, 2024

Yeah, that's a tricky one to fix because the item text given by the client doesn't say what each section is for (doesn't say what part is the implicits or what part is explicits etc) so my program has to make educated guesses. It usually works, but if the explicits section starts with an affix that isn't supported/detected then it won't show. The good news is even though it won't show, the program will still remember it, and it'll show up as soon as I add support for it.

from pathofbuilding.

Openarl avatar Openarl commented on August 16, 2024

The program now supports "Socketed Gems are Supported by" modifiers, which were the main cause of this issue, so I'll mark this as closed.

from pathofbuilding.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.