Map<String,Object> incorrectly validated about openapi4j HOT 3 CLOSED

Thanks for the report, now map is directly converted to JsonNode and more generally, content "primitives" (i.e. not object or array) are now mapped regardless what the type is supposed to be. Wrong content type is now converted to string node instead of null node for better error reports.

Are you able to confirm the fix in latest snapshot?

from openapi4j.

Thanks that appears to have resolved those simple test cases using strings and integers.

(i.e. not object or array) are now mapped regardless what the type is supposed to be.

Does this suggest that objects and arrays are mapped according to the spec rather than the data object type? I think there will be issues if you use the spec for anything during conversion without doing full validation.

The use of discriminators means the data is polymorphic and cannot be converted using the spec without doing full validation. A property may be a string or an object/hash, depending on the value of another property.

Is there any reason you can't inspect the object and see if it is a hash or a list rather than using the spec? The jackson libraries may have some helpers to do this.

from openapi4j.

I wrote this for other un-structured content types (x-www-form-urlencoded) and parameters (cookies, query, ...) also combined with defined styles. Map<String, Object> as input is fine here.

For the others, I'll digg into it for in a separate issue but it may be impossible to achieve. Let's take an example for a query parameter with exploded form style : /users?id=5 without the schema we can't determine if it's a primitive or an array with a single value in the collection. This is also true for x-www-form-urlencoded content type as an Encoding Object can be defined to setup a style.

from openapi4j.