Comments (11)
Welcome and thank you for the report.
The issue is about the format validator which did not detect the null value.
Can you confirm the fix in the latest snapshot? It should be already available.
from openapi4j.
@llfbandit Thank you for the quick response.
Where is 0.6-SNAPSHOT
being published? I can't seem to find it in the maven repo.
Also, is there an estimate on when 0.6 will be released?
from openapi4j.
You have to add https://oss.sonatype.org/content/repositories/snapshots
before accessing snapshot versions.
I'm waiting for #28 confirmation before bumping to 0.7 so a couple of days I would say.
from openapi4j.
You have to add
https://oss.sonatype.org/content/repositories/snapshots
before accessing snapshot versions.I'm waiting for #28 confirmation before bumping to 0.7 so a couple of days I would say.
The above test throws a NullPointerException
with 0.6-SNAPSHOT
. It seems to be coming from ReferenceValidator. More specifically, schemaParentNode.get(ABS_REF_FIELD)
is null
. The schema parent node contains a normal $ref
instead of an absolute ref. Aren't both valid in that context?
from openapi4j.
This is due to the usage of toNode
which serialize the content with constraints to reflect the definition of OAI. The field ABS_REF_FIELD
is not exported in this case. This why you get the RuntimeException.
If you really use the toolset like with the reproducer you'll need to use TreeUtil.toJsonNode
to keep the info.
To let me know, what kind of usage do you have? For this kind of validation process, the operation validator is dedicated to make the glue code between parser and schema validation modules.
from openapi4j.
I updated the code to JsonNode jsonNode = TreeUtil.toJsonNode(schema);
but I am still getting the same NullPointerException
. I updated the test case in the original post accordingly so it can be reproduced.
from openapi4j.
To let me know, what kind of usage do you have? For this kind of validation process, the operation validator is dedicated to make the glue code between parser and schema validation modules.
We are using the schema validator to validate input and output payloads against the schemas defined in the OpenAPI definition of the REST API.
from openapi4j.
0.6 introduced this bug. Sorry for that.
This invalidates 0.6 as a release for now. You can follow up this subsequent fix to the dedicated issue #28.
from openapi4j.
0.6 introduced this bug. Sorry for that.
This invalidates 0.6 as a release for now. You can follow up this subsequent fix to the dedicated issue #28.
Ok thank you I will keep an eye on #28
from openapi4j.
Can you validate this issue ? We're pretty close to conclude on the other side. Thank you.
from openapi4j.
Validated. Seems to be fixed. Thank you very much for the quick turnaround.
from openapi4j.
Related Issues (20)
- int64 or int32 format not identified by openapi4j tool HOT 3
- Mandatory element missing is not throwing error HOT 3
- Some of the optional fields when using oneOf are not being validated HOT 1
- Convenience methods to support easy response validation HOT 3
- Spring Adapter
- Validating data against schema with $ref HOT 2
- Incorrect path pattern for path parameter HOT 2
- Creating schema references programatically HOT 7
- OpenApi3Parser - add ability to provide spec string/stream to parse method HOT 2
- Integer formats not identified in 1.0.5 version openapi4j tool HOT 1
- Scheme that contains path parameters with minus sign in name fails validation HOT 1
- Throw ValidationException on path pattern collision
- Give the option to throw a validation error with no response validator is found
- RequestValidator fails when path params contains minus char HOT 1
- Get the path of an operation HOT 2
- ADDITIONAL_PROPS_RESTRICT = true rejects all attributes HOT 1
- Duplicate properties, Duplicate Headers are not being validated HOT 2
- Remove toString() call to replace NPE with more meaningful message
- Validation of callback URLs can't handle allOf/oneOf/... HOT 3
- Path pattern collision leads to incorrect Path selection
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openapi4j.