Set token to empty value about extension-utilitiespack HOT 12 CLOSED

@anangaur Any idea about this?

from extension-utilitiespack.

@pascalberger Yes this is a bug. I will try to fix it asap.

from extension-utilitiespack.

I tried setting an environment variable in powershell with empty value and it doesn't set that variable.
[Environment]::SetEnvironmentVariable("TestVariable", "", "User") (This doesn't set the env variable)

I think an env variable with empty value means you are unsetting that environment variable and thus it is no longer passes the test-path env:$matchedItem check.

from extension-utilitiespack.

@harshil93 Yes this was also my observation. Any approach how this should be solved? Would setting an empty value in case neither environment variable was set nor value was found in configuration be an option?

from extension-utilitiespack.

@harshil93 @anangaur Any opinion about this?

from extension-utilitiespack.

I agree with @pascalberger. If an environment variable is unset (i.e. not found in configuration) by means of assigning it to an empty string, then the replaced variable should default to an empty string. i.e in the very last else block of the tokenise.ps1 script:
Write-Host "No value found for token '$match' - setting to empty string"
$variableValue = [string]::Empty
works fine for me at the moment.

from extension-utilitiespack.

I've created a PR for this: #48. @harshil93 @anangaur Any chance to get this merged and released?

from extension-utilitiespack.

@pascalberger - One issue I can see with setting a not defined variable to an empty is breaking existing behavior if someone later in their tasks is doing something with unassigned variables.

Given this, I think an optional checkbox option telling user to replace undefined with empty ones would be better rather than just changing the behavior.

from extension-utilitiespack.

@harshil93 Thanks for the feedback. I'll update the PR with a user checkbox. But propably will wait until #50 is merged and rebase on this.

from extension-utilitiespack.

@pascalberger The PR is merged. If you want to contribute to this. Go ahead.

from extension-utilitiespack.

@harshil93 Since you have closed this issue do you already merge the PR (#48)? Otherwise the issue is not fixed...

from extension-utilitiespack.

@pascalberger I will try to get it merged by today. Reopening the issue till it get merged.

from extension-utilitiespack.