Giter Club home page Giter Club logo

Comments (6)

mx-psi avatar mx-psi commented on July 22, 2024 3

To be clear: service.telemetry.metrics.level is also not standard YAML notation. There is no standard to refer to nested keys in a YAML document as far as I am aware.

from opentelemetry.io.

mx-psi avatar mx-psi commented on July 22, 2024 2

The main downside of dot notation I see (which is the reason we use :: for referring to nested keys) is that OpenTelemetry semantic conventions use dots for namespacing and we occasionally use semantic conventions as the name of configuration settings.

To put a concrete example, take the following dockerstats receiver configuration from its README:

receivers:
  docker_stats:
    metrics:
      container.cpu.percent:
        enabled: false
      container.cpu.utilization:
        enabled: true

This configuration disables the container.cpu.percent metric and enables the container.cpu.utilization metric. How do you refer to the setting that does this? Using ::, you have receivers::docker_stats::metrics::container.cpu.percent, but if you use dots it becomes ambiguous (receivers.docker_stats.metrics.container.cpu.percent) and one doesn't know where to split for nesting

from opentelemetry.io.

svrnm avatar svrnm commented on July 22, 2024 1

The main downside of dot notation I see (which is the reason we use :: for referring to nested keys) is that OpenTelemetry semantic conventions use dots for namespacing and we occasionally use semantic conventions as the name of configuration settings.

That's a great reason and we should put it that way in the doc, what do you think @tiffany76 ?

from opentelemetry.io.

svrnm avatar svrnm commented on July 22, 2024

@open-telemetry/collector-approvers @open-telemetry/collector-maintainers please take a look

from opentelemetry.io.

theletterf avatar theletterf commented on July 22, 2024

I'd rather use the dot notation, which is more Pythonesque and hence closer to Python? Although depending on the language one might recognize :: as a namespace notation. Slashes are another option.

See https://github.com/wwkimball/yamlpath/wiki/Segments-of-a-YAML-Path

from opentelemetry.io.

tiffany76 avatar tiffany76 commented on July 22, 2024

Sounds good to me, @svrnm, @mx-psi . I will make the addition today. Thanks!

from opentelemetry.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.