Use semconv span naming in ActionPack about opentelemetry-ruby-contrib HOT 5 OPEN

Shouldn't >= 7.1 be #{request.method} #{request.route_uri_pattern} instead?

@karmingc yes!

from opentelemetry-ruby-contrib.

+1 for ActionDispatch::Request#route_uri_pattern

Personally I would like to keep the existing naming convention as config opt if possible, it's just such a useful railism and Action Pack is rails instrumentation, just saying 😄

from opentelemetry-ruby-contrib.

... I would like to keep the existing naming convention ... it's just such a useful railism

I've heard similar from other Rails folks instrumenting with OTel. The Rails world currently thinks in the names Rails has given and not so much thinking in the OTel semantics. Maybe that will change as more people adopt OTel and polyglot shops start wondering why their Rails web request handling spans are named differently than the spans from other services in their larger system.

from opentelemetry-ruby-contrib.

Shouldn't >= 7.1 be #{request.method} #{request.route_uri_pattern} instead?

from opentelemetry-ruby-contrib.

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

from opentelemetry-ruby-contrib.