When the operator isn't up and running, removing resources will fail with: <div cl

Great! This will be straightforward to implement then, <a class="user-mention notransl

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Deletion of resources shouldn't fail if the webhook server isn't available about opentelemetry-operator HOT 5 CLOSED

open-telemetry commented on June 14, 2024

Deletion of resources shouldn't fail if the webhook server isn't available

from opentelemetry-operator.

Comments (5)

jpkrohling commented on June 14, 2024 2

This would allow deletion of the resource, but would leave the cleanup of the underlying resources to the user, including removing finalizers when applicable

Not sure we do anything at all in our code. When a CR is deleted, all the resources that are owned by this CR are deleted automatically. In our reconciliation function, we'll see the delete event but won't find the CR, in which case we'll just return. So, I think your idea would work nicely.

opentelemetry-operator/controllers/opentelemetrycollector_controller.go

Lines 116 to 125 in 543ff61

 if err := r.Get(ctx, req.NamespacedName, &instance); err != nil { 

 if !apierrors.IsNotFound(err) { 

 log.Error(err, "unable to fetch OpenTelemetryCollector") 

 } 

 // we'll ignore not-found errors, since they can't be fixed by an immediate 

 // requeue (we'll need to wait for a new notification), and we can get them 

 // on deleted requests. 

 return ctrl.Result{}, client.IgnoreNotFound(err) 

 }

from opentelemetry-operator.

gramidt commented on June 14, 2024 1

Great! This will be straightforward to implement then, @jpkrohling. This is now in my backlog to tackle.

from opentelemetry-operator.

jpkrohling commented on June 14, 2024 1

Go ahead! Can you please double-check the kubebuilder docs to see if they have a recommendation about this? What we have right now is following what was bootstrapped by kubebuilder when I first bootstrapped this operator, and things might have changed since then.

from opentelemetry-operator.

gramidt commented on June 14, 2024

@jpkrohling - One potential thought is to split the "validating-webhook-configuration" into two validating webhooks. The second one would be for the "DELETE" and would have failurePolicy: Ignore. This would allow deletion of the resource, but would leave the cleanup of the underlying resources to the user, including removing finalizers when applicable. Thoughts?

from opentelemetry-operator.

VineethReddy02 commented on June 14, 2024

@jpkrohling I can work on this!

from opentelemetry-operator.

Recommend Projects

Deletion of resources shouldn't fail if the webhook server isn't available about opentelemetry-operator HOT 5 CLOSED

Comments (5)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	if err := r.Get(ctx, req.NamespacedName, &instance); err != nil {
	if !apierrors.IsNotFound(err) {
	log.Error(err, "unable to fetch OpenTelemetryCollector")
	}

	// we'll ignore not-found errors, since they can't be fixed by an immediate
	// requeue (we'll need to wait for a new notification), and we can get them
	// on deleted requests.
	return ctrl.Result{}, client.IgnoreNotFound(err)
	}