Giter Club home page Giter Club logo

Comments (8)

RassK avatar RassK commented on July 26, 2024

src/Datadog.Trace.ClrProfiler.Managed/Datadog.Trace.ClrProfiler.Managed.csproj

Are you sure about this? ... to me it doesn't seem like deprecated.

from opentelemetry-dotnet-instrumentation.

nrcventura avatar nrcventura commented on July 26, 2024

src/Datadog.Trace.ClrProfiler.Managed/Datadog.Trace.ClrProfiler.Managed.csproj

Are you sure about this? ... to me it doesn't seem like deprecated.

I listed it as deprecated based on the comments within the csproj file.

<PackageDescription>
DEPRECATED. This package exists only for backwards compatibility. If your project references this package ("Datadog.Trace.ClrProfiler.Managed") or "Datadog.Trace.AspNet", you can remove them both.
.NET Core applications no longer require any NuGet package to enable automatic instrumentation.
Automatic instrumentation for both ASP.NET and ASP.NET Core is now automatically enabled.
Users who need manual instrumentation should reference the "Datadog.Trace" package.
</PackageDescription>

from opentelemetry-dotnet-instrumentation.

pellared avatar pellared commented on July 26, 2024

src/Datadog.Trace.ClrProfiler.Managed/Datadog.Trace.ClrProfiler.Managed.csproj

Are you sure about this? ... to me it doesn't seem like deprecated.

I listed it as deprecated based on the comments within the csproj file.

<PackageDescription>
DEPRECATED. This package exists only for backwards compatibility. If your project references this package ("Datadog.Trace.ClrProfiler.Managed") or "Datadog.Trace.AspNet", you can remove them both.
.NET Core applications no longer require any NuGet package to enable automatic instrumentation.
Automatic instrumentation for both ASP.NET and ASP.NET Core is now automatically enabled.
Users who need manual instrumentation should reference the "Datadog.Trace" package.
</PackageDescription>

This is a note for NuGet package consumers. We do not want to publish any NuGet from this repository.

from opentelemetry-dotnet-instrumentation.

RassK avatar RassK commented on July 26, 2024

So the conclusion is to remove project 1 and cleanup nuget packaging references from 2?

from opentelemetry-dotnet-instrumentation.

nrcventura avatar nrcventura commented on July 26, 2024

So the conclusion is to remove project 1 and cleanup nuget packaging references from 2?

That works for me. The original intention of this issue was to reduce the number of things that need to be maintained.

from opentelemetry-dotnet-instrumentation.

zacharycmontoya avatar zacharycmontoya commented on July 26, 2024

As discussed in the SIG meeting, the contents of both these projects are still in use, but the DEPRECATED message was a signal to users that the NuGet packages would no longer be produced. So we just need to remove the NuGet information from these projects

from opentelemetry-dotnet-instrumentation.

pellared avatar pellared commented on July 26, 2024

Moreover, I think the examples using the Datadog.Tracer NuGet package should be removed as well. More: #155 (comment)

Thanks @lucaspimentel for the comment 👍

from opentelemetry-dotnet-instrumentation.

pellared avatar pellared commented on July 26, 2024

Not longer valid.

from opentelemetry-dotnet-instrumentation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.