Memory leaks during key creation and signing about oqs-provider HOT 4 CLOSED

Yes, no problem, I will try to fix the last leak and open a pull request.

from oqs-provider.

Please submit your fixes via PR from your own fork. A nice summary has recently been posted by Thom Wiggers to the oqs-developers mailing list:

The way PRs work on Github is that you create a copy of a repository under your own account (a so-called fork), add this fork as a "remote" to your local copy of the repository, and then push your changes to the fork under your github account. You can then open a pull request (so-called because it's a request to pull changes from your git repository!) through the command line.

See also: https://docs.github.com/en/get-started/quickstart/contributing-to-projects

from oqs-provider.

@xShuusui Thanks very much for this heads-up. Indeed, valgrind testing for this code base is missing :-( As you have already done it, would you have time/willingness to contribute this via a PR? That would allow me to focus on fixing the bugs.

from oqs-provider.

@baentsch Do i have the permissions to create a branch in this repository? I have fixed it locally but cannot push it.

from oqs-provider.