Giter Club home page Giter Club logo

Comments (11)

baentsch avatar baentsch commented on July 23, 2024

We can make the binary available (if that helps!).

The approach to "build static" sounds good -- what would help me is a (windows?) script building everything as you recommend, triggering testing (both good and failing), ideally using gnu-type tooling. A pure binary is something I wouldn't know how to debug into (which tools to use as I assume they depend on your build environment, right?).

from oqs-provider.

mingw-io avatar mingw-io commented on July 23, 2024

Some (extra) testing: client/server

image

image

from oqs-provider.

mingw-io avatar mingw-io commented on July 23, 2024

It is evident that we lack some experience on Windows, which is perfectly fine!
On Windows, we can use the same toolchain we use on Mac & Linux (a.k.a. GNU GCC & cmake).
On the command line (e.g. cmd) I type in:

  • cmake -DCMAKE_INSTALL_PREFIX=<some folder here> ..
  • cmake --build

That's it!

To simplify your life as well as end users' life, I will be attaching a simple installer for you to try.

from oqs-provider.

baentsch avatar baentsch commented on July 23, 2024

On Windows, we can use the same toolchain we use on Mac & Linux (a.k.a. GNU GCC & cmake).

Just to make it clear for a simple mind like me: I need to download and install all software from https://sourceforge.net/projects/mingw/, then run cmake -DCMAKE_INSTALL_PREFIX=<some folder here> .. && cmake --build? No need to add anything along the lines of

set(CMAKE_FIND_LIBRARY_SUFFIXES ".a")
set(BUILD_SHARED_LIBS OFF)
set(CMAKE_EXE_LINKER_FLAGS "-static")

?

from oqs-provider.

mingw-io avatar mingw-io commented on July 23, 2024

Hi.
Find attached a OneClick installer for testing/verification purposes. We hope you find it useful.

image

oqs-provider-0.4.0-x64.zip

from oqs-provider.

baentsch avatar baentsch commented on July 23, 2024

Thanks very much for this installer. I am now confused by the introductory statement, though:

as some failing tests demonstrate (e.g. oqs_endecode

When trying out the installer and the test programs contained, no test fails (?). So did you manage to resolve all problems? If so, would you consider contributing your work e.g., to resolve this issue, #80 and #47 ?

from oqs-provider.

baentsch avatar baentsch commented on July 23, 2024

@mingw-io ping/Did you see the questions above?

from oqs-provider.

mingw-io avatar mingw-io commented on July 23, 2024

Ciao there.
It is up to this project maintainer(s) to make up their minds about how to proceed/move forward!

Regarding issue #80 my tests have demonstrated the oqs-provider does NOT support OpenSSL statically linked.
This issue (#82) is related to #80.
All issues (#47, #80 & this one) are resolved on my end.

Now we need to ask ourselves how to proceed here.
I have noticed that some/many (end) users have difficulties in either building OQS from source and/or setting it up and/or using it.

I could contribute some binaries/installer with no dependencies at all (e.g. Visual Studio, etc).
The installer provided above contains three oqs official tests. When you run them, all should pass. If not, please let me know.

from oqs-provider.

baentsch avatar baentsch commented on July 23, 2024

I could contribute some binaries/installer with no dependencies at all (e.g. Visual Studio, etc).

PR would be welcome.

The installer provided above contains three oqs official tests. When you run them, all should pass. If not, please let me know.

I do not have a Windows installation to test. We'd expect any contribution to contain CI features (for the specific platform, i.e., Windows in this case) such as to not depend on manual testing.

from oqs-provider.

baentsch avatar baentsch commented on July 23, 2024

#201 seems to resolve this issue.

from oqs-provider.

baentsch avatar baentsch commented on July 23, 2024

Resolved by #201

from oqs-provider.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.