Provider context type clarification about go-sdk HOT 5 CLOSED

Changes were made following this issue happy to reopen

from go-sdk.

I will add comments to references to make this change seem more intentional

from go-sdk.

@rgrassian-split, does this make sense to you? Do you have any concerns?

from go-sdk.

@beeme1mr I softly disagree and think the provider having to look up the exact string to fetch the targeting key from the map is just as troublesome as / worse than having to make an additional fetch to attributes before accessing custom attributes. It's just a soft disagree though, overall it's pretty minor and fine with either.

from go-sdk.

One benefit to decoupling the 2 types (context passed by the client, and context passed to a provider) is that we can make changes to the client facing api without requiring all providers to be updated with the new types, although this does nto necessarily have to come in the form of the FlattenedContext, and of course if only relevant if the EvaluationContext type is subject to change

from go-sdk.