Comments (3)
I like this approach a lot, I think this resolves any of the concerns with the alternatives I had found. Thanks @james-milligan , I’ll proceed with this method
from go-sdk.
we could create an UnimplementedHook
struct to be placed within any new hooks, this unimplemented hook would contain all the required, but empty, methods to satisfy the interface. A developer would then 'replace' the unimplemented methods with their own:
https://go.dev/play/p/XXcPF3ffLMS
this pattern is seen in grpc generated code and I believe will help with the reduction in breaking changes if, for example, a new method is added. Any implemented methods should still break the interface if they change
from go-sdk.
If we go ahead with this we lose any type assurances at compile time. A developer can no longer be confident that their hook will get called as anything will be accepted as a hook (and subsequently not called if it doesn't match one of the before/after/error/finally funcs).
If, for example, the hook interface gets changed down the line in a breaking change, any developers who update the sdk would know immediately that they needed to update their hooks. If, however, we've made this change they wouldn't see any compile time errors and their hooks would cease to work silently.
I'm now of mind that keeping the interface as it is provides more benefits (at the cost of forcing developers to have empty functions). Thoughts? @james-milligan @beeme1mr @toddbaert
from go-sdk.
Related Issues (20)
- Update README to be consistent with other SDKs
- Changes to support spec `v0.6.0` compliance HOT 4
- implement named client support: open-feature/spec@4cf8229 HOT 1
- implement initialization/shutdown: open-feature/spec@a4ffec3
- Implement event support HOT 1
- Conform to spec `v0.7.0` HOT 6
- event handlers should run immediately if the associated provider is in the state associated with that handler already
- [FEATURE] Follow official Go guidance on how to organize a module? HOT 9
- [FEATURE] Follow up for 227 HOT 2
- [BUG] Panic when following getting started tutorial HOT 2
- [FEATURE] Blocking provider mutator HOT 1
- [FEATURE] Expose domain specific provider metadata getter HOT 1
- [FEATURE] Upgrade to Go version 1.20
- [FEATURE] Implement transaction context HOT 5
- [FEATURE] Implement domain scoping HOT 2
- [FEATURE] Make provider interface "stateless", SDK maintains provider state
- Should retrieving a value really provide an error? HOT 5
- [FEATURE] Move to log/slog logging HOT 2
- [BUG] Awkward usage when trying to evaluate a boolean flag in a complex conditional HOT 8
- [FEATURE] New test-oriented client HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-sdk.