Giter Club home page Giter Club logo

Comments (3)

beeme1mr avatar beeme1mr commented on August 16, 2024 1

Technically this isn't required by the spec. Perhaps the go lang SDK simply doesn't support a context transformer.

There was recently a proposal to add support to the spec for provider hooks. Perhaps that would be sufficient in this case.

from go-sdk.

skyerus avatar skyerus commented on August 16, 2024

Without having access to generics implementing this requirement isn't as trivial as one would hope.

If I've understood the intent, we want to allow providers to transform the EvaluationContext into their own custom type.

The only way I can envision this happening is by changing the FeatureProvider's EvaluationContext function parameter to the interface{} type. This isn't ideal as it'd mean that the Provider would be forced to assert the EvaluationContext's type in its calls. This would be especially cumbersome for Providers that don't want to transform an EvaluationContext, they'd still be forced to assert the interface{} to EvaluationContext.

Is this an acceptable downside? Can we find another way of achieving this behaviour without burdening the Providers with the type assertions?

@toddbaert @beeme1mr @james-milligan

from go-sdk.

skyerus avatar skyerus commented on August 16, 2024

Technically this isn't required by the spec. Perhaps the go lang SDK simply doesn't support a context transformer.

There was recently a proposal to add support to the spec for provider hooks. Perhaps that would be sufficient in this case.

As this isn't strictly required by the spec I'm closing this. Perhaps it can be revisited when upgrading to 1.18

from go-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.