Comments (3)
Technically this isn't required by the spec. Perhaps the go lang SDK simply doesn't support a context transformer.
There was recently a proposal to add support to the spec for provider hooks. Perhaps that would be sufficient in this case.
from go-sdk.
Without having access to generics implementing this requirement isn't as trivial as one would hope.
If I've understood the intent, we want to allow providers to transform the EvaluationContext into their own custom type.
The only way I can envision this happening is by changing the FeatureProvider's EvaluationContext
function parameter to the interface{}
type. This isn't ideal as it'd mean that the Provider would be forced to assert the EvaluationContext
's type in its calls. This would be especially cumbersome for Providers that don't want to transform an EvaluationContext
, they'd still be forced to assert the interface{}
to EvaluationContext
.
Is this an acceptable downside? Can we find another way of achieving this behaviour without burdening the Providers with the type assertions?
@toddbaert @beeme1mr @james-milligan
from go-sdk.
Technically this isn't required by the spec. Perhaps the go lang SDK simply doesn't support a context transformer.
There was recently a proposal to add support to the spec for provider hooks. Perhaps that would be sufficient in this case.
As this isn't strictly required by the spec I'm closing this. Perhaps it can be revisited when upgrading to 1.18
from go-sdk.
Related Issues (20)
- [ci] Configure renovate
- [ci] Configure cycloneDX for SBOM generation
- [TESTS] Introduce fuzzing tests
- [ci] Implement renovate config that watches test-harness version
- Absorb extracted test suite from go-sdk-contrib
- [FEATURE] Validate EvaluationContext's keys/values are UTF-8?
- [FEATURE] Generics for v2 release of go-sdk HOT 1
- [FEATURE] Propagate request context HOT 3
- [BUG] Cache isn't invalidated properly HOT 5
- Update README to be consistent with other SDKs
- Changes to support spec `v0.6.0` compliance HOT 4
- implement named client support: open-feature/spec@4cf8229 HOT 1
- implement initialization/shutdown: open-feature/spec@a4ffec3
- Implement event support HOT 1
- Conform to spec `v0.7.0` HOT 6
- event handlers should run immediately if the associated provider is in the state associated with that handler already
- [FEATURE] Follow official Go guidance on how to organize a module? HOT 9
- [FEATURE] Follow up for 227 HOT 2
- [BUG] Panic when following getting started tutorial HOT 2
- [FEATURE] Blocking provider mutator HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-sdk.