Multiple implementations about open-dis-csharp HOT 6 CLOSED

I had a look at the repo, and I've made a branch on a fork to start looking at this. The below is a summary of what I found:

• C#/DIS#1.0Examples is identical to C#/Examples, except the later has binaries included
  • Action Taken: Remove C#Examples - commit ae65eea
• All *.cs files directly in Csharp are empty - with the Subdirectories having the actual code in them.
  • Action Taken: Remove Csharp/*.cs - commit 7bc33a4
• According to C#/DIS#1.0/Readme.txt, C#/DIS#1.0 is code generated from open-dis_3.1.3.jar, presumably an old version open-dis-java.
  • Action Taken: Remove C#/DIS#1.0/ - commit c6f32a1

Beyond that, I'm not sure. My original instinct was to remove C# all together, but C#/DIS#2.0/ is the only directory that has been modified since the Initial Check-in commit, including:

• a commit regarding the correction of some bitwise operations
• and, the addition of some test apps

C#/DIS#2.0/OpenDis does have a Dis1998 folder, so that is Version 6, yeah?

Oh, CSharpDis7 seems to be the only thing to reference dis7.

DISCLAIMER: My DIS knowledge is limited, I've been hunting through the issues for somethings I can do to learn more. Above decisions were made purely off diffing & grepping files, and the C#/DIS#1.0 ReadMe.txt file

from open-dis-csharp.

@rodneyp290 thank you this is a fantastic analysis! I'll be looking at your PR in a moment.

from open-dis-csharp.

I've also just now renamed the C#/Dis#2.0 folder to CSharpDis6 to be more clear now.

from open-dis-csharp.

Now just to figure out what to do with the Csharp folder. I think it's another Dis6 implementation.

from open-dis-csharp.

Ok Csharp folder was identical to https://github.com/open-dis/open-dis-csharp/tree/master/CsharpDis6/OpenDis/Dis1998/Generated. So I'm removing Csharp.

Thanks for your help getting the ball rolling @rodneyp290

from open-dis-csharp.

No Problem. Glad I could help out 👍

from open-dis-csharp.