Giter Club home page Giter Club logo

Comments (2)

vsivsi avatar vsivsi commented on August 30, 2024

Hi, your observation is correct regarding the parameters of call vs. apply. I noticed this myself when I first started using this package... But, this proposal, and the accompanying PR are a breaking change to this package, correct?

So all dependent packages that use the .call method to invoke Meteor methods (a sizable fraction, I would estimate) will break with the next update and need to change?

As I said above, I agree that the incongruity here is unfortunate, but this package has a fairly long list of dependents. As such, I would argue that this ship has sailed, so to speak, and we should just live with it, at least until some more pressing breaking changes are warranted, necessitating a full 1.0 semver major release. IMO, this is a nicety, but not worth all of the fuss it seems likely to cause.

from node-ddp-client.

license2e avatar license2e commented on August 30, 2024

@vsivsi I see your point, but that would just be an easy fix:

  1. next version announce API change with backward compatibility (ie. .call* would just call .send*)
  2. also, just designate that 1 or 2 versions from now the call would be deprecate
  3. iteration 2, start issuing console.log warnings (like other libraries do)
  4. when deprecating the call, just throw an exception for all the .call* functions
  5. iteration 3 just remove all together

In my experience, when developers are upgrading code, as long as you dont just change the API completely without a fair warning, they are ok with it.

I can add all the backward compatibility to my PR..

from node-ddp-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.