Comments (2)
Hi, your observation is correct regarding the parameters of call
vs. apply
. I noticed this myself when I first started using this package... But, this proposal, and the accompanying PR are a breaking change to this package, correct?
So all dependent packages that use the .call
method to invoke Meteor methods (a sizable fraction, I would estimate) will break with the next update and need to change?
As I said above, I agree that the incongruity here is unfortunate, but this package has a fairly long list of dependents. As such, I would argue that this ship has sailed, so to speak, and we should just live with it, at least until some more pressing breaking changes are warranted, necessitating a full 1.0 semver major release. IMO, this is a nicety, but not worth all of the fuss it seems likely to cause.
from node-ddp-client.
@vsivsi I see your point, but that would just be an easy fix:
- next version announce API change with backward compatibility (ie.
.call*
would just call.send*
) - also, just designate that 1 or 2 versions from now the call would be deprecate
- iteration 2, start issuing console.log warnings (like other libraries do)
- when deprecating the call, just throw an exception for all the
.call*
functions - iteration 3 just remove all together
In my experience, when developers are upgrading code, as long as you dont just change the API completely without a fair warning, they are ok with it.
I can add all the backward compatibility to my PR..
from node-ddp-client.
Related Issues (20)
- result undefined HOT 2
- Memory and cpu increases when server goes down (socket close) HOT 2
- Initial added not being detected? HOT 2
- Error: process.nextTick is not a function HOT 5
- Use with react native Android? HOT 1
- Advice to connect to localhost from Raspberry Pi HOT 1
- Collections are not cleaned on `close` HOT 1
- How to Stop Subscription? HOT 1
- Update `faye-websocket` version HOT 8
- Connection to galaxy hosted meteor app from DO node server fails HOT 3
- DDP Connection Idle Disconnect HOT 3
- A method to know if ddp is connected/closed
- Callback never called HOT 5
- Reason for reconnect? HOT 2
- Using in the browser? HOT 1
- Security vulnerability in dependency HOT 1
- Connecting to meteor server using ROOT_URL HOT 1
- process.binding is not supported
- Methods are not resolved when reconnecting
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-ddp-client.