Giter Club home page Giter Club logo

ip's Introduction

Hi there, I'm Jun Xiong

I'm a Student and a Developer

  • ๐Ÿ”ญ Iโ€™m currently studying in NUS (Computer Science)!
  • ๐ŸŒฑ Iโ€™m currently learning ML and BlockChain!
  • ๐Ÿ’ฌ View my portfolio website here

Connect with me:

codeSTACKr | LinkedIn codeSTACKr | Instagram


Languages and Tools:

Visual Studio Code HTML5 CSS3 Java JavaScript React Node.js SQL MySQL MongoDB Git GitHub Python



Anurag's github stats

ip's People

Contributors

damithc avatar j-lum avatar jiachen247 avatar ong6 avatar

ip's Issues

Sharing iP code quality feedback [for @ong6]

We did an automated analysis of your code to detect potential areas to improve the code quality. We are sharing the results below, to help you improve the code further.

IMPORTANT: Note that the script looked for just a few easy-to-detect problems only, and at-most one example is given i.e., there can be other areas/places to improve.

Aspect: Tab Usage

No easy-to-detect issues ๐Ÿ‘

Aspect: Brace Style

No easy-to-detect issues ๐Ÿ‘

Aspect: Package Name Style

No easy-to-detect issues ๐Ÿ‘

Aspect: Class Name Style

No easy-to-detect issues ๐Ÿ‘

Aspect: Dead Code

No easy-to-detect issues ๐Ÿ‘

Aspect: Method Length

Example from src/main/java/duke/Parser.java lines 41-97:

    private String identifyInput(String input) throws DukeGeneralException, DukeTaskException, IOException {
        Task temp;
        String output;
        switch (getCommand(input)) {
        case "bye":
            try {
                storage.save(tasks);
            } catch (IOException e) {
                return duke.Ui.showLoadingError();
            }
            output = duke.Ui.showBye();
            break;
        case "list":
            if (tasks.isEmpty()) {
                return duke.Ui.showDukeEmptyListError();
            }
            output = duke.Ui.showList(tasks);
            break;
        case "find":
            output = duke.Ui.showFind(tasks, getMessage(input).trim());
            break;
        case "done":
            tasks.setDone(duke.Ui.getIndex(input));
            output = duke.Ui.showDone(input, tasks);
            break;
        case "todo":
            temp = new ToDo(getMessage(input));
            output = duke.Ui.showTaskAdded(tasks, temp);
            tasks.add(temp);
            break;
        case "deadline":
            temp = new Deadline(getMessage(input));
            output = duke.Ui.showTaskAdded(tasks, temp);
            tasks.add(temp);
            break;
        case "event":
            temp = new Event(getMessage(input));
            output = duke.Ui.showTaskAdded(tasks, temp);
            tasks.add(temp);
            break;
        case "delete":
            output = duke.Ui.showDeleteTask(input, tasks);
            tasks.remove(duke.Ui.getIndex(input));
            break;
        case " ":
            output = duke.Ui.showEmptyError();
            break;
        case "archive":
            String archivePath = getMessage(input).trim();
            output = duke.Ui.showArchiveTasks(tasks, archivePath);
            storage.archive(tasks, archivePath);
            break;
        default:
            throw new DukeGeneralException("");
        }
        return output;
    }

Suggestion: Consider applying SLAP (and other abstraction mechanisms) to shorten methods. You may ignore this suggestion if you think a longer method is justified in a particular case.

โ„น๏ธ The bot account @cs2103-bot used to post this issue is un-manned. Do not reply to this post (as those replies will not be read). Instead, contact [email protected] if you want to follow up on this post.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.