Giter Club home page Giter Club logo

Comments (9)

onevcat avatar onevcat commented on May 16, 2024

Hi, @alexdd55

Thanks.

It is an interesting feature and could be achieved if we implement a multi-cache system.

However, currently there is not a good way to do such things in Kingfisher since its single cache structure. A possible solution would be set/replace different cache object in the shared KingfisherManager object. But there is risk of thread issues since the cache property is not thread safe now.

It will not be difficult to add this feature but the hardest part is how to design the API.

I will consider it later. Thank you.

from kingfisher.

alexdd55 avatar alexdd55 commented on May 16, 2024

thanks for the quick answer. :)

from kingfisher.

onevcat avatar onevcat commented on May 16, 2024

Oh, I guess we'd better leave it open since there is possibility to add it later. :)

It is a cool feature.

from kingfisher.

onevcat avatar onevcat commented on May 16, 2024

By the way, if you need to separate the disk cache duration, a possible way for now would be giving up the UIImageView category (the kf_setImageWithURL methods), but to use the downloader and cache classes solely.

You are always free create and config your own cache with a name and duration. When you need an image, just check if a url is already cached there. If not, you can download with the default downloader and then store it in the cache you need. Although it is a bit hard to use :(

from kingfisher.

alexdd55 avatar alexdd55 commented on May 16, 2024

you right, keep that open :)

this is not a showstopper, it would just be very comfortable ;)

from kingfisher.

onevcat avatar onevcat commented on May 16, 2024

Implemented in #30 . Waiting for merging.

from kingfisher.

alexdd55 avatar alexdd55 commented on May 16, 2024

nice! 👍

from kingfisher.

onevcat avatar onevcat commented on May 16, 2024

Added in version 1.2.0

Now you can use this code to use different caches for your images:

let avatarCache = ImageCache(name: "avatar")
avatarCache.maxCachePeriodInSecond = 100

let contentCache = ImageCache(name: "content")
contentCache.maxCachePeriodInSecond = 200

avatarImageView.kf_setImageWithURL(NSURL(string: "avatar_image_url")!, 
                                                         placeholderImage: nil, 
                                            optionsInfo: [.TargetCache: avatarCache])

contentImageView.kf_setImageWithURL(NSURL(string: "content_image_url")!, 
                                                           placeholderImage: nil, 
                                              optionsInfo: [.TargetCache: contentCache])

Please let me know whether it works for you. Please notice that the options APIs are now deprecated, and you need to switch to the new optionsInfo version.

from kingfisher.

alexdd55 avatar alexdd55 commented on May 16, 2024

what can i say? Awesome Job! 👍

I might test it over the weekend.
Great work!

from kingfisher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.