[Bug]: [OneSignalRequest urlRequest] Crash about onesignal-ios-sdk HOT 4 OPEN

Hi @danhalliday, thanks for reporting.

• Is this all the information from the crash log?

• Is there any information about what the error is like this:

Exception Type:  EXC_BREAKPOINT (SIGTRAP)
Exception Codes: 0x0000000000000001, 0x0000000102afb3d0

• How many users / what percent of users have been affected by this crash?
• I have some clues what could be happening here, but to confirm, do you ever call login with an external_id that could contain potentially problematic characters?
  • Such as special characters like @ # " ' [ ] / \ . , ;, or non-English characters, etc?
  • What type of characters are used in your external_id?

from onesignal-ios-sdk.

@nan-li All our user IDs are UUIDs, with the usual format (eg. 3a0e68e4-7cc3-4602-ac61-131d00222d01). This doesn't seem to be something that would cause an issue with URL encoding or other serialisations.

Given the nanov2_guard_corruption_detected stack frame surely this is a thread safety issue?

from onesignal-ios-sdk.

Hi @danhalliday, thanks for confirming your user IDs.

The reason it looks like URL encoding or serialization to me, from first glance is the stack trace leading up to the crash is creating an NSURL instance.

1. [OneSignalClient prettyPrintDebugStatementWithRequest:] followed by [OneSignalRequest urlRequest] leads to this line of code which is printing a debug statement.

2. Which then calls into the creation of the NSURL [NSURL(NSURL) URLWithString:relativeToURL:] in this line of code.

from onesignal-ios-sdk.