add makeHorizontalCoordinates(with geographicCoordinates: GeographicCoordinates) to CelestialBody Protocol about swiftaa HOT 4 CLOSED

Hi. Thanks for your message. Indeed, this could be added.

I've spent so much time trying to factor out everything, and play with this powerful Swift pattern which is protocol-oriented programming. But sometimes, I missed a few details in the global view.

I am glad it helped you in different ways. Don't hesitate to support it on patreon, it if you wish. ;-)

from swiftaa.

I am currently moving the func makeHorizontalCoordinates(with geographicCoordinates: GeographicCoordinates) -> HorizontalCoordinates function from the Sun class to the CelestialBody protocol.

The little change is that it now uses self.equatorialCoordinates and not self.apparentEquatorialCoordinates as it was in the Sun class.

Hence to be consistent, I kept the method in the Sun class, with the existing implementation, but renaming it more correctly makeApparentHorizontalCoordinates(with geographicCoordinates: GeographicCoordinates) -> HorizontalCoordinates

Consequently: the Sun class has hence both methods: the standard one from the CelestialBodyprotocol, and the "apparent" one as a specific implementation.

from swiftaa.

I'll wait for closing #100 and #101 before making a patch release.

from swiftaa.

Already done.

from swiftaa.