Comments (4)
Hi @mrousavy nice to see you here. We do have an interest in but with some concerns. Libraries like react-native-quick-crypto
, @craftzdog/react-native-buffer
, react-native-quick-base64
, react-native-bignumber
are quite new and not battle-tested like the pure js counterparts. I've seen some issues like craftzdog/react-native-quick-base64#3 margelo/react-native-bignumber#55 , which showed some inconsistency and prevented us to adopt. So I think the first priority to promote is to have test suites to make sure the new implementations are 100% compatible with the classic ones.
from app-monorepo.
Hi @mrousavy
Thanks for your suggestion, our project is a fully cross platform project with web and browser extension in addition to ios/android, this is a very critical reason why we didn't choose the native crypto library before like react-native-quick-crypto.
If using react-native-quick-crypto. It is necessary to encapsulate different functions executed for different platforms in some crypto-related function. This is a very troublesome workload, which may affect our sprint, so we have temporarily selected a library that is relatively unified across platforms and used by many wallets, but as a direction for performance optimization in the future, we will consider this native library.
from app-monorepo.
Hey @loatheb!
Thanks for your suggestion, our project is a fully cross platform project with web and browser extension in addition to ios/android, this is a very critical reason why we didn't choose the native crypto library before like react-native-quick-crypto.
react-native-quick-crypto automatically falls back to react-native-crypto (aka crypto-browserify) if a native function isn't available (which is the case on web). :)
Hi @sunnylqm! 👋
For react-native-bignumber, we used the same tests as for BN.js. Apparently this specific case isn't covered by the BN.js tests?
We can take a closer look at that issue soon. We'd appreciate any feedback, e.g. if you notice similar issues or inconsistencies
As for battletesting/security, react-native-bignumber and react-native-quick-crypto both use OpenSSL under the hood. OpenSSL is pretty established 😅
from app-monorepo.
2023 update: react-native-quick-crypto is now becoming much more popular and widely adopted now, and both react-native-crypto & crypto-browserify have abandoned maintenance.
We should definitely reconsider this suggestion. Especially, we are having a hard time dealing with performance issues now...
cc @huhuanming @loatheb @sidmorizon
from app-monorepo.
Related Issues (20)
- KASPA not shown after fresh installation of OneKey wallet on windows 7 HOT 3
- Add support for QTUM blockchain HOT 1
- [BUG]:Unable to resolve "@onekeyhq/app/src/hardware/OnekeyLite" from "../kit/src/views/Hardware/OnekeyLite/Backup/index.tsx" HOT 1
- [BUG]: Transactions with USDC/Sol are not executed (pending forever) HOT 5
- [BUG]: can't connect to tokenproof.xyz HOT 5
- [Feature] HOT 1
- [BUG]: HOT 1
- [BUG]: HOT 1
- [BUG]:
- The experience of onekey in android HOT 2
- [BUG]:png format pictures cannot be displayed normally
- 钱包在这次升级后conflux espace网络出现抓取GAS费失败的情况,望技术团队尽快处理 HOT 1
- [BUG]: Bitcoin chain cannot be signed using the 'signature' function. HOT 6
- [BUG]: 拉去代码运行报错ios HOT 13
- [Feature] 请求mini和classic1代支持FIDO2和GPG智能卡功能 HOT 1
- Support Electroneum (ETN) Network HOT 1
- [BUG]: lock now feature was unresponsive HOT 1
- [Feature] History should show received transactions, not only sent transactions
- offering support for zcash ( zec )
- [QUESTION] How onekey calculates tokens security risks based on what? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from app-monorepo.