Comments (3)
Thanks Josh.
Is the behavior of the authorization server well-specified in standards in this error case? By my reading of the Error Response portion of OAuth 2.0 spec, it seems that a compliant behavior would be to redirect the client browser to the redirect URI (since it isn't an issue with the redirect URI or client id), with an error
param that matches one of the legal values, and a state
param.
Since the aud
param was added by the SMART App Launch Framework spec from what I can tell (not seeing it in OAuth 2.0 spec), it isn't clear what that error code must be though. Looks like the SMART App Launcher passes error=bad_audience&error_description=Bad%20audience%20value
, though that error value isn't technically valid according to the OAuth 2.0 spec. It is also missing the state
parameter, which is problematic for Inferno as a client because that is how we reattach users to a running test session.
Did I get that right?
from inferno-community.
I think your assessment is correct and that the SMART launcher needs some work to ensure that it is compliant (and as far as the launcher goes, there are some intentionally strange behaviors, like we don't validate client secrets for example).
The key issue is to make sure that a server does not issue a token if a correct aud
wasn't supplied.
from inferno-community.
Ok, I understand the issue. Will see how we can add a test for this. Thanks!
from inferno-community.
Related Issues (20)
- Device error Device.type: This property must be an Array, not an Object HOT 1
- Encounter error, Encounter.type[0].coding[0].system: URL value 'http://www.ama-assn.org/go/cpt' does not resolve HOT 3
- Observation test -Invalid Observation: Observation: Unrecognised property '@encounter' HOT 1
- v2.12.0 test C-02 fails for valid capability statements HOT 1
- docker image v2.12.0 shows 2.11.0 in the UI HOT 2
- Clinical Notes Guideline Tests does not include patient id in url HOT 4
- US Core v3.1.0 option in not available in v2.12.0. HOT 2
- Most of the tests fails with 404 Not Found fatal error HOT 1
- is there ruby scripts test against these guidelines such as "HL7 CARIN BB, DaVinci PDEX, PlanNet & Formulary guidelines"
- Inferno server crashing frequently from database issues HOT 2
- docker-compose up does not work HOT 1
- database contention issues HOT 2
- USCPROV-03 thinks "This server does not support Provenance search,read operation(s)" while it does HOT 4
- USCDRRN complain the returned reports donβt have LaboratorySlice while they explicitly ask for non-lab reports HOT 2
- Data missing on Provenance for Diagnostic Report when available on DiagnosticReport.Provenance and url. HOT 1
- inferno jwks keys support only key_ops and does not include use=sig HOT 1
- Community Inferno showing snomed url as invalid for some fhir endpoint, ex. procedure.code.system HOT 1
- SMART Launches redirect to arbitary SMART Scheduling Links test session if system under test omits `state`
- pickup bulk data test (bdt) updates to address bulk data auth test issues HOT 1
- π₯ Do not post issues here for Inferno or ONC Certification (g)(10) Test Kit. Please read for correct locations.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from inferno-community.