Comments (3)
Sure, no problem. I'm using the fork for now. I'll test these cases tomorrow, most probably it should work as google-api-python-client
also attaches the body part first and does it always:
https://github.com/googleapis/google-api-python-client/blob/2565803cd363f48cf3c00a23cd8760bd6db4de06/googleapiclient/discovery.py#L1138
Also can you please take a quick look at the implementation there, just to be sure I'm not missing something.
from aiogoogle.
Thanks @nkitsaini
I just checked and your suggested change works as expected.
I just pushed a fix and will release it in the 2.0.1 version.
from aiogoogle.
Hey @nkitsaini
Thanks for taking the time to file this issue!
I'm suspecting that attaching a None json part might break some of the APIs supported by this lib like Google Drive and Google Cloud Store. So, I still need to test these. I'm on a vacation now, so unfortunately, I can't run any tests. Should be all done in 5-7 days.
If you're on a hurry, you can help me test these changes and I will merge your PR right after you can confirm that both Google Drive and Google Cloud Store are able to upload multipart files with:
- json = None
- json being appended before the body.
Thanks again!
from aiogoogle.
Related Issues (20)
- Ability to upload from AsyncIterable object HOT 6
- Can we provide a way to test the package end to end? HOT 1
- URL formatting issue HOT 3
- URL encoding issues with Calendar IDs HOT 1
- Aiogoogle doesn't support the beta Drive Labels API HOT 5
- Token is not getting refreshed after its expired after around 1 hour HOT 17
- Inconsistent response. HOT 5
- Unclosed client session HOT 4
- URL formatting breaks the people.connections.list method HOT 1
- Updating google drive file contents yields corrupted file due to multipart HOT 5
- Authentication using application default method HOT 1
- HttpError doesn't include JSON error response with the "pipe_to" option enabled HOT 1
- paginn issue HOT 2
- Requesting Google Drive list with multiple pages always results in user_creds of None HOT 3
- Issue with `ServiceAccountCreds` with `universe_domain` HOT 2
- FYI sending messages with Gmail doesn't work HOT 1
- UserCreds oauth token not refreshed after 1hour HOT 1
- `trio` support broken: unexpected keyword argument 'auth_manager' HOT 3
- Should attributes in `HTTPError` be type annotated? HOT 1
- Module import error : contextvars HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aiogoogle.