Giter Club home page Giter Club logo

Comments (3)

nkitsaini avatar nkitsaini commented on June 13, 2024 1

Sure, no problem. I'm using the fork for now. I'll test these cases tomorrow, most probably it should work as google-api-python-client also attaches the body part first and does it always:
https://github.com/googleapis/google-api-python-client/blob/2565803cd363f48cf3c00a23cd8760bd6db4de06/googleapiclient/discovery.py#L1138
Also can you please take a quick look at the implementation there, just to be sure I'm not missing something.

from aiogoogle.

omarryhan avatar omarryhan commented on June 13, 2024 1

Thanks @nkitsaini
I just checked and your suggested change works as expected.
I just pushed a fix and will release it in the 2.0.1 version.

from aiogoogle.

omarryhan avatar omarryhan commented on June 13, 2024

Hey @nkitsaini

Thanks for taking the time to file this issue!
I'm suspecting that attaching a None json part might break some of the APIs supported by this lib like Google Drive and Google Cloud Store. So, I still need to test these. I'm on a vacation now, so unfortunately, I can't run any tests. Should be all done in 5-7 days.

If you're on a hurry, you can help me test these changes and I will merge your PR right after you can confirm that both Google Drive and Google Cloud Store are able to upload multipart files with:

  1. json = None
  2. json being appended before the body.

Thanks again!

from aiogoogle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.